From owner-svn-ports-head@freebsd.org  Wed Oct 31 11:48:22 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54FE710D4979;
 Wed, 31 Oct 2018 11:48:22 +0000 (UTC)
 (envelope-from swills@FreeBSD.org)
Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "mouf.net", Issuer "mouf.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id EDE0070EBF;
 Wed, 31 Oct 2018 11:48:21 +0000 (UTC)
 (envelope-from swills@FreeBSD.org)
Received: from lrrr.mouf.net (cpe-174-109-174-192.nc.res.rr.com
 [174.109.174.192]) (authenticated bits=0)
 by mouf.net (8.14.9/8.14.9) with ESMTP id w9VBmDWO055966
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
 Wed, 31 Oct 2018 11:48:19 GMT (envelope-from swills@FreeBSD.org)
Subject: Re: svn commit: r483541 - in head/net-mgmt/prometheus2: . files
To: Alexey Dokuchaev <danfe@freebsd.org>, Jan Beich <jbeich@freebsd.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
References: <201810310144.w9V1i4pO035552@repo.freebsd.org>
 <20181031015036.GA11773@FreeBSD.org> <8t2e-pzvc-wny@FreeBSD.org>
 <20181031033142.GA782@FreeBSD.org>
From: Steve Wills <swills@FreeBSD.org>
Message-ID: <b1834077-b7da-8822-11e3-fde57939df58@FreeBSD.org>
Date: Wed, 31 Oct 2018 07:48:08 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181031033142.GA782@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mouf.net [199.48.129.64]); Wed, 31 Oct 2018 11:48:20 +0000 (UTC)
X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net
X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net
X-Virus-Status: Clean
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 11:48:22 -0000

Hi,

On 10/30/18 11:31 PM, Alexey Dokuchaev wrote:
> 
> I understand it's too late, I didn't ask for message amendment.  My point
> was that this information (perhaps in its concise form) should be included
> in the commit log, so whoever reading the diff months/years later could do
> that without Bugzilla access in order to understand the problem behind the
> commit, how it was fixed, and why it was fixed the way it was.
> 

I agree commit messages these days tend to be light on explanations of 
why things are done and it would be nice if they explained more the 
reasoning behind a commit in general.

This one was complicated and I was tired and couldn't come up with a 
suitably short description that would still be useful, so I figured the 
PR reference would have to be sufficient.

Steve