From owner-svn-src-all@freebsd.org Wed Mar 7 15:38:03 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D197CF37F2C for ; Wed, 7 Mar 2018 15:38:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6228D7B6E3 for ; Wed, 7 Mar 2018 15:38:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x233.google.com with SMTP id n136so1259276itg.5 for ; Wed, 07 Mar 2018 07:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=k/QE485AcSSYnJ0GzUzSKXYy8E+VdmtLuXrwbxXEPhs=; b=Jfr5texUrPBh6yf2+2BTz+kaLD95SMLlFfv3Sb+0lhZri61OVO0ivl/S5q/o1wLoQG /OaDHzR7jFf4fzpOBbCJ6eUE5afcNKjuv9bFSnpuVQ3vYrmVTCAgagK0f5DpyNF9nLeQ fx97TdUwjoZO4CyrM7NfY+6b8KUPqDJGd7zE8EIsvfe/bh7DKQGv2N7euINq0HKi8V+f pjoBycddV9rvy8g2CI7MTFcqtdri3WN2zZ4LybCgKOsDqZdCGIufX0WOpc/eFj6wU9Qu +OiR2pksbRbZQ8B8mGFI6zj6kCbclBuWHgOonDndCa5wFz71IagsG9Esbg9EfC6rIfad QJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=k/QE485AcSSYnJ0GzUzSKXYy8E+VdmtLuXrwbxXEPhs=; b=CaB7Lp4flnLEqLYr35WrrbHaPU7jbeySinUhq79ts8O0pud33SB4C5LXflYd0CcW7M nh9tmrLKdshQDFlUfEtQHi9IQ80T4Ew5ekCaa9sz4nGWHtD2cDvgCDPhp+AvKmZ2cjV6 WBtxqz2Mdl5a5BT/lH/I0f6hLnqjFlhM56c5cbXtp1JBBj4Fi5MSBVz18QO//BixWWpa NRiiZAUCpWZQMaem959fwOgZ7+BxzxWZNLRyHbx6cI4Y10t4p9NnibLgpeqB6H5fXqM1 bOG0xj/m+hT+LH4F5wYf7D5caAOQUzdfprQoXHvO5/JO23pQFym0nl5pnQgRslhz1yJv 7psQ== X-Gm-Message-State: AElRT7FDuqwkb1plb/nO3RUBzThD4o163kiFoRYY2U2JgK+CxPcLHebi 0uDwcuWaP7CLFYztRNQVRa0UG2zT417snVAtSxkySQ== X-Google-Smtp-Source: AG47ELtxkvnhPcrZdwdCSDJU0eLDKLA2t3ffFTjoL85ajy1kgELHuVtAu8k6G+rKBhd8TKZ/aw3mr5cntzMTxoB90NA= X-Received: by 10.36.16.147 with SMTP id 141mr23909825ity.73.1520437081601; Wed, 07 Mar 2018 07:38:01 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.203.196 with HTTP; Wed, 7 Mar 2018 07:38:00 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: References: <201803071444.w27EiWBV053244@repo.freebsd.org> From: Warner Losh Date: Wed, 7 Mar 2018 08:38:00 -0700 X-Google-Sender-Auth: PkYEb97KJ8My_-ug5KNeQpzLMuQ Message-ID: Subject: Re: svn commit: r330601 - head/sys/i386/ibcs2 To: Oliver Pinter Cc: Eitan Adler , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 15:38:03 -0000 The message is right if you s/cloudabi/ibcs/ though. Warner On Wed, Mar 7, 2018 at 8:29 AM, Oliver Pinter wrote: > Wrong commit message. IBCS isn't cloudabi. > > On Wednesday, March 7, 2018, Eitan Adler wrote: > >> Author: eadler >> Date: Wed Mar 7 14:44:32 2018 >> New Revision: 330601 >> URL: https://svnweb.freebsd.org/changeset/base/330601 >> >> Log: >> sys: Fix a few potential infoleaks in cloudabi >> >> While there is no immediate leak, if the structure changes underneath >> us, there might be in the future. >> >> Submitted by: Domagoj Stolfa >> MFC After: 1 month >> Sponsored by: DARPA/AFRL >> >> Modified: >> head/sys/i386/ibcs2/ibcs2_ipc.c >> >> Modified: head/sys/i386/ibcs2/ibcs2_ipc.c >> ============================================================ >> ================== >> --- head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:41:29 2018 >> (r330600) >> +++ head/sys/i386/ibcs2/ibcs2_ipc.c Wed Mar 7 14:44:32 2018 >> (r330601) >> @@ -135,6 +135,8 @@ ibcs2_msgctl(struct thread *td, void *v) >> struct msqid_ds bs; >> int error; >> >> + memset(&is, 0, sizeof(is)); >> + >> switch (uap->cmd) { >> case IBCS2_IPC_STAT: >> error = kern_msgctl(td, uap->msqid, IPC_STAT, &bs); >> @@ -317,6 +319,8 @@ ibcs2_semctl(struct thread *td, void *v) >> union semun semun; >> register_t rval; >> int error; >> + >> + memset(&is, 0, sizeof(is)); >> >> switch(uap->cmd) { >> case IBCS2_IPC_STAT: >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >