Date: Wed, 23 Jun 2010 12:16:32 -0700 From: Xin LI <delphij@delphij.net> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: d@delphij.net, freebsd-stable@FreeBSD.org, Mario Sergio Fujikawa Ferreira <lioux@freebsd.org> Subject: Re: FreeBSD 8.1-PRERELEASE: WARNING ioctl sign-extension ioctl ffffffff8004667e Message-ID: <4C225D90.9020100@delphij.net> In-Reply-To: <201006231510.50863.jkim@FreeBSD.org> References: <20100623025855.82916.qmail@exxodus.fedaykin.here> <4C225572.8020602@delphij.net> <201006231501.38985.jkim@FreeBSD.org> <201006231510.50863.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------030000090201040702030204 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2010/06/23 12:10, Jung-uk Kim wrote: > It is still a kludge and it won't be fixed. :-( Another thought - what about just hiding the printf under #ifdef DIAGNOSTIC... I don't really see any reason why we must print it out if we truncate it every time... Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iQEcBAEBCAAGBQJMIl2QAAoJEATO+BI/yjfBpz0IAM88YOx5CVoYRCEW8EwCaW+N 5Ugks9hCvbsJgU2yLxeg5hGal0wOHKONLxaq9pXvQFybgRT9SLmna2FJLTJ6XYTu pjtjeby40mpwRTwU5rZgJ//aYgHW48kK9N/CoE63zKycYQbjLFGnZmXbel9itZzL Xnpj9kc0zlpqtk6yZd4XA+m90VrIgnMKmxeP0A5OzuWJKUBmvciqSMYEBQ0pkP03 sSiN5QIzW/gRMgYSJEsTGz5+q10ZDf0NOecuhOujLphWLzWxkq6UOqRi3JXvFaqo ajRDpGEG65r2IDd8qo4y50U0FGeHmysTFUPU3aAOzjb10LbNbmT6zX+3G1rSMFY= =A2pe -----END PGP SIGNATURE----- --------------030000090201040702030204 Content-Type: text/plain; name="sys_generic.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="sys_generic.c.diff" Index: sys/kern/sys_generic.c =================================================================== --- sys/kern/sys_generic.c (revision 209472) +++ sys/kern/sys_generic.c (working copy) @@ -628,9 +628,11 @@ caddr_t data; if (uap->com > 0xffffffff) { +#ifdef DIAGNOSTIC printf( "WARNING pid %d (%s): ioctl sign-extension ioctl %lx\n", td->td_proc->p_pid, td->td_name, uap->com); +#endif uap->com &= 0xffffffff; } com = uap->com; --------------030000090201040702030204--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C225D90.9020100>