Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Sep 2008 17:59:29 -0700 (PDT)
From:      Fritz Katz <frtzkatz@yahoo.com>
To:        freebsd-multimedia@freebsd.org
Subject:   Is this a bug? (in /usr/src/sys/dev/bktr/bktr_os.c )
Message-ID:  <542052.24495.qm@web63007.mail.re1.yahoo.com>

next in thread | raw e-mail | index | archive | help
In FreeBSD-7.0, /usr/src/sys/dev/bktr/bktr_os.c, line 469:

http://fxr.watson.org/fxr/source/dev/bktr/bktr_os.c?v=FREEBSD70#L469
__________

fail:
  if (bktr->res_irq)
     bus_release_resource(dev, SYS_RES_IRQ, bktr->irq_rid, bktr->res_irq);
  if (bktr->res_mem)
     bus_release_resource(dev, SYS_RES_IRQ, bktr->mem_rid, bktr->res_mem);
  return error;
__________

Shouldn't the type field for the second bus_release_resource be SYS_RES_MEMORY?  Would it cause a kernel panic if it were ever hit?  If it is a bug, it's probably been there for years.

Cheers,
-- Fritz Katz.







      



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?542052.24495.qm>