Date: Thu, 09 Dec 2010 22:29:27 -0700 From: "Janky Jay, III" <ek@purplehat.org> To: ohauer@FreeBSD.org Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/151637: Update port: security/maia Much needed updates for Perl and PHP. Message-ID: <4D01BAB7.2040802@purplehat.org> In-Reply-To: <201012051932.oB5JWw0l058016@freefall.freebsd.org> References: <201012051932.oB5JWw0l058016@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Olli, Excellent information. Thanks! I'll make these changes as soon as I can and re-submit the port (in diff format as I hear that's the proper way.) Regards, Janky Jay, III On 12/05/2010 12:32 PM, ohauer@FreeBSD.org wrote: > Synopsis: Update port: security/maia Much needed updates for Perl and PHP. > > State-Changed-From-To: open->feedback > State-Changed-By: ohauer > State-Changed-When: Sun Dec 5 19:31:55 UTC 2010 > State-Changed-Why: > I'll take it. > > Hi Janky Jay, > > I've taken a look over your second patch, looks good so far but I have > a view questions and suggestions. > > Are those php modules really needed? > For example if I do not use mysql but postgres insted do I need the > module mysql and mysqli? > > If this is not the case then this the preferred solution > > .if defined(WITH_MYSQL) > USE_MYSQL= yes > USE_PHP+= mysql mysqli > RUN_DEPENDS+= ${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databases/p5-DBD-mysql > .endif > > Same for postgres and others. > > As you see in the Makefile snipped before I removed mysql-server > with USE_MYSQL, same for postgres and apache. > Maybe the sql servers are running on a different machine/cluster? > > In your first patch you had additional php-filter, is this module not > needed or was it forgotten in the second patch? > > > It seems you rolled the tar file from the maia 1.0 branch, rev 1499. > > Here I have the following suggestion. > Do not use the same name for the sources, use DISTNAME instead. > > For example: > svn co https://www.maiamailguard.com/svn/branches/1.0 -r1500 maia-1.0.2a-r1500 > > Now you can use in Makefile > DISTNAME= ${PORTNAME}-${PORTVERSION}-${SVNREVISION} > and > SVNREVISION= r1500 > > This way there is no distinfo clash and it helps paranoid users like > me to compair the sources ;) > > > I've implemented some of the suggested changes, within an update to > svn revision 1500. You can find them here. > > Diff to current port > http://people.freebsd.org/~ohauer/diffs/PR_151637-maia_2010-12-05.diff > > New resulting port (svn updated to rev 1500) > http://people.freebsd.org/~ohauer/diffs/PR_151637-maia_2010-12-05.shar > > Please look into the php modules and if possible build the source tar > as suggested. > > -- > Regards, > olli > > > Responsible-Changed-From-To: freebsd-ports-bugs->ohauer > Responsible-Changed-By: ohauer > Responsible-Changed-When: Sun Dec 5 19:31:55 UTC 2010 > Responsible-Changed-Why: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=151637 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0BurcACgkQZ5znzUsaCyRoVQCeLVNDfel7i3+YHA+BSuglAaUI UQwAn2Tl9g3FehP8dOsGpdGD8h8SkJsi =L03u -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D01BAB7.2040802>