From owner-svn-src-all@freebsd.org  Mon Mar 11 06:23:17 2019
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C74D1532036;
 Mon, 11 Mar 2019 06:23:17 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9D153845BC;
 Mon, 11 Mar 2019 06:23:16 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 8CF91777D; Mon, 11 Mar 2019 06:23:16 +0000 (UTC)
Date: Mon, 11 Mar 2019 06:23:16 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Justin Hibbits <chmeeedalf@gmail.com>
Cc: svn-src-head@freebsd.org, Justin Hibbits <jhibbits@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc
Message-ID: <20190311062316.GA41091@FreeBSD.org>
References: <201903090318.x293IcLc023548@repo.freebsd.org>
 <20190309085058.GA60945@FreeBSD.org>
 <20190310171640.31bb9c54@titan.knownspace>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190310171640.31bb9c54@titan.knownspace>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 9D153845BC
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.97 / 15.00];
 NEURAL_HAM_MEDIUM(-0.99)[-0.991,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.98)[-0.983,0]
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2019 06:23:17 -0000

On Sun, Mar 10, 2019 at 05:16:40PM -0500, Justin Hibbits wrote:
> On Sat, 9 Mar 2019 08:50:58 +0000
> Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote:
> > > New Revision: 344960
> > > URL: https://svnweb.freebsd.org/changeset/base/344960
> > > 
> > > Log:
> > >   powerpc: Print trap frame address for fatal traps
> > >   
> > >   MFC after:	1 week
> > > 
> > > Modified: head/sys/powerpc/powerpc/trap.c
> > > ...
> > > current msr     = 0x%" PRIxPTR "\n", mfmsr()); printf("
> > > lr              = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr,
> > > frame->lr - (register_t)(__startkernel - KERNBASE));
> > > +	printf("   frame           = %p\n", frame);
> > >  	printf("   curthread       = %p\n", curthread);
> > 
> > Some of those are printed with %PRIxPTR, some with %p.  Perhaps this
> > inconsistency can be avoided?
> 
> PRIxPTR is for printing a pointer-like value that's not a pointer.
> The other values printed are of type register_t, not void *.

Ah, okay, I've somehow missed that, thanks for pointing this out.

./danfe