Date: Mon, 11 Sep 2006 01:11:37 +0800 From: Gea-Suan Lin <gslin@gslin.org> To: Erwin Lansing <erwin@FreeBSD.org>, perl@FreeBSD.org Cc: gslin@gslin.org Subject: Re: ports/102757: [PATCH] net/p5-POE-Component-Client-Ident: update to 1.02 Message-ID: <20060910171137.GA50143@gslin.org> In-Reply-To: <20060910164003.GX80138@droso.net> <cb5206420609040049l2cdf17c2s468ee89d98571c58@mail.gmail.com> References: <20060910163355.1CB488B@netnews.NCTU.edu.tw> <20060910164003.GX80138@droso.net> <200609040050.k840oPGN033868@freefall.freebsd.org> <cb5206420609040049l2cdf17c2s468ee89d98571c58@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Sun, Sep 10, 2006 at 06:40:03PM +0200, Erwin Lansing wrote:
> Hi,
>
> On Mon, Sep 11, 2006 at 12:33:55AM +0800, Gea-Suan Lin wrote:
> >
> > -RUN_DEPENDS= p5-Compress-Zlib>=1.34:${PORTSDIR}/archivers/p5-Compress-Zlib \
> > +BUILD_DEPENDS= p5-Compress-Zlib>=1.34:${PORTSDIR}/archivers/p5-Compress-Zlib \
> > p5-POE>=0.3501:${PORTSDIR}/devel/p5-POE
> > -BUILD_DEPENDS= ${RUN_DEPENDS}
> > +RUN_DEPENDS:= ${BUILD_DEPENDS}
> >
> Can you explain the reasoning behind this change? Apart from the
> versioning for p5-POE, I don't see a big advantage at using the :=
> assignment here, but I'm happy to be proven wrong.
>
> Cheers,
> -erwin
This is because the dicussion:
On Mon, Sep 04, 2006 at 11:49:50AM +0400, Andrew Pantyukhin wrote:
> On 9/4/06, Gea-Suan Lin <gslin@gslin.org> wrote:
> > On Sun, Sep 03, 2006 at 01:35:53PM +0400, Andrew Pantyukhin wrote:
> > > On 9/1/06, Gea-Suan Lin <gslin@gslin.org> wrote:
> > > >- Use BUILD_DEPENDS=${RUN_DEPENDS} to avoid unused dependency
> > > >
> > > >-BUILD_DEPENDS= ${SITE_PERL}/POE.pm:${PORTSDIR}/devel/p5-POE
> > > >-RUN_DEPENDS= ${BUILD_DEPENDS}
> > > >+RUN_DEPENDS= ${SITE_PERL}/POE.pm:${PORTSDIR}/devel/p5-POE
> > > >+BUILD_DEPENDS= ${RUN_DEPENDS}
> > >
> > > Frankly, I don't understand this. Can you elaborate, please?
> >
> > This prevents from unused dependency in the future.
> >
> > For example, in the past, if using USE_REINPLACE=yes with
> > BUILD_DEPENDS=${RUN_DEPENDS}, it will cause sed_inplace in run-depend.
> >
> > Another one is using PERL_MODBUILD=yes with same condition, it will
> > add p5-Module-Build into BUILD_DEPENDS.
>
> You're right, but RUN_DEPENDS can also be appended
> later by things we don't want in BUILD_DEPENDS.
>
> The real solution is:
>
> BUILD_DEPENDS= xxx yyy ...
> RUN_DEPENDS:= ${BUILD_DEPENDS}
>
> This make these two variables independent of each other.
> I suggest you use it in the future.
>
> Thanks!
--
* Gea-Suan Lin (public key: Using https://keyserver.pgp.com/ to search)
* If you cannot convince them, confuse them. -- Harry S Truman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060910171137.GA50143>