From owner-cvs-all Sat Dec 15 14:54:58 2001 Delivered-To: cvs-all@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 6868337B445; Sat, 15 Dec 2001 14:54:28 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.11.3/8.11.3) with ESMTP id fBFMrq8110358; Sat, 15 Dec 2001 17:53:56 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu (Unverified) Message-Id: In-Reply-To: <20011214102915.L49775@iguana.aciri.org> References: <20011214094310.A25238@dragon.nuxi.com> <200112141803.fBEI3MU02957@grimreaper.grondar.org> <20011214102915.L49775@iguana.aciri.org> Date: Sat, 15 Dec 2001 17:53:49 -0500 To: Luigi Rizzo , Mark Murray From: Garance A Drosihn Subject: Re: Are prototypes for main() illegal by any standard ? (was Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 10:29 AM -0800 12/14/01, Luigi Rizzo wrote: >Anyways, i think we should not make a big deal out of this. > >Is it illegal, by any standard, to supply prototypes for main() ? > >If not, what is wrong in casually adding them whenever you happen >to touch those files ? Personally, I think your commit was fine. I can see someone being unhappy if you emailed *them* and told *them* to add a prototype for main(), but I personally don't see what's wrong with you adding the prototype if you feel like doing it. As near as I can see, the argument against your change boils down to "we changed gcc in -current so you should not need to add a prototype to avoid these warnings in -current". I do not find that to be a convincing reason to back out the change. There are more C compilers in the world than the gcc we happen to have in -current right now, and if adding the prototype does not *break* anything then I see no reason for anyone to feel bad if someone else feels like adding it. If adding the prototype for main() does *break* something, then it would be helpful to find out what it is that breaks. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message