From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Oct 29 23:40:19 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6CC816A4CE for ; Fri, 29 Oct 2004 23:40:19 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A09043D41 for ; Fri, 29 Oct 2004 23:40:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i9TNeGP0020500 for ; Fri, 29 Oct 2004 23:40:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9TNeGXN020497; Fri, 29 Oct 2004 23:40:16 GMT (envelope-from gnats) Resent-Date: Fri, 29 Oct 2004 23:40:16 GMT Resent-Message-Id: <200410292340.i9TNeGXN020497@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sven Berkvens-Matthijsse Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5E6516A4CE for ; Fri, 29 Oct 2004 23:39:15 +0000 (GMT) Received: from berkvens.net (ip5452aa82.speed.planet.nl [84.82.170.130]) by mx1.FreeBSD.org (Postfix) with SMTP id 6FAAA43D41 for ; Fri, 29 Oct 2004 23:39:14 +0000 (GMT) (envelope-from sven@berkvens.net) Received: (qmail 57956 invoked by uid 103); 29 Oct 2004 23:39:12 -0000 Message-Id: <20041029233912.57955.qmail@cat.berkvens.net> Date: 29 Oct 2004 23:39:12 -0000 From: Sven Berkvens-Matthijsse To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/73297: [patch] libmatroska port upgrade to 0.7.4 fails on FreeBSD 4.10 if a previous version of libmatroska is already installed X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Sven Berkvens-Matthijsse List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2004 23:40:19 -0000 >Number: 73297 >Category: ports >Synopsis: [patch] libmatroska port upgrade to 0.7.4 fails on FreeBSD 4.10 if a previous version of libmatroska is already installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Fri Oct 29 23:40:16 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Sven Berkvens-Matthijsse >Release: FreeBSD 4.10-STABLE i386 >Organization: De Kattenfabriek >Environment: System: FreeBSD cat.berkvens.net 4.10-STABLE FreeBSD 4.10-STABLE #3: Thu Sep 16 23:19:36 CEST 2004 sven@cat.berkvens.net:/extra0/usr_obj/usr/src/sys/CAT i386 >Description: I had the port multimedia/libmatroska version 0.7.1 installed on my FreeBSD 4.10 system. I tried to use portupgrade to upgrade it to version 0.7.4, which is the most current version in the ports tree at this time. portupgrade was not able to upgrade the port and reported a "Bad C++ code" error. The problem is that the Makefile in /usr/ports/multimedia/libmatroska has some lines saying: .if ${OSVERSION} < 500000 CFLAGS+= -DNO_WSTRING -I${LOCALBASE}/include .endif The code of libmatroska uses lines like #include and because of the -I${LOCALBASE}/include will look for those files in /usr/local/include/matroska first (which is the previously installed version of libmatroska, not the new version). Those header files are obviously out of date for the new version, so the compile fails because the wrong header files are used. Changing the lines above to: .if ${OSVERSION} < 500000 CFLAGS+= -DNO_WSTRING -idirafter ${LOCALBASE}/include .endif solves the problem for me, because /usr/local/include is placed after the other paths that the port adds with the -I option to the compiler. >How-To-Repeat: * Install version 0.7.1 of libmatroska on your system * Try to portupgrade libmatroska to 0.7.4 >Fix: Change /.../multimedia/libmatroska/Makefile lines: .if ${OSVERSION} < 500000 CFLAGS+= -DNO_WSTRING -I${LOCALBASE}/include .endif to: .if ${OSVERSION} < 500000 CFLAGS+= -DNO_WSTRING -idirafter ${LOCALBASE}/include .endif >Release-Note: >Audit-Trail: >Unformatted: