From owner-svn-src-all@freebsd.org Wed May 11 21:50:32 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B778CB3795E; Wed, 11 May 2016 21:50:32 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 35A9F16C5; Wed, 11 May 2016 21:50:32 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci To: "Bjoern A. Zeeb" , Andrew Turner References: <201605111707.u4BH7UXs040026@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Jung-uk Kim Message-ID: Date: Wed, 11 May 2016 17:50:27 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dbepT12CGabjDgX7GV0qt71I7DPxJbh8V" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 21:50:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dbepT12CGabjDgX7GV0qt71I7DPxJbh8V Content-Type: multipart/mixed; boundary="gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK" From: Jung-uk Kim To: "Bjoern A. Zeeb" , Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci References: <201605111707.u4BH7UXs040026@repo.freebsd.org> In-Reply-To: --gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/16 05:38 PM, Bjoern A. Zeeb wrote: >=20 >> On 11 May 2016, at 17:07 , Andrew Turner wrote: >> >> Author: andrew >> Date: Wed May 11 17:07:29 2016 >> New Revision: 299467 >> URL: https://svnweb.freebsd.org/changeset/base/299467 >> >> Log: >> Add a new get_id interface to pci and pcib. This will allow us to bot= h >> detect failures, and get different PCI IDs. >> >> For the former the interface returns an int to signal an error. The I= D is >> returned at a uintptr_t * argument. >> >> For the latter there is a type argument that allows selecting the ID = type. >> This only specifies a single type, however a MSI type will be added >> to handle the need to find the ID the hardware passes to the ARM GICv= 3 >> interrupt controller. >> >> A follow up commit will be made to remove pci_get_rid. >> >> Reviewed by: jhb, rstone >> Obtained from: ABT Systems Ltd >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D6239 >=20 > Hi, seems gcc, I guess it is, doesn=E2=80=99t like your change: >=20 > In file included from /scratch/tmp/bz/head.svn/sys/sparc64/isa/ofw_isa.= c:78: > ./pcib_if.h:166: warning: 'enum pci_id_type' declared inside parameter = list > ./pcib_if.h:166: warning: its scope is only this definition or declarat= ion, which is probably not what you want > ./pcib_if.h:169: warning: 'enum pci_id_type' declared inside parameter = list > ./pcib_if.h:169: error: parameter 3 ('type') has incomplete type > ./pcib_if.h: In function 'PCIB_GET_ID': > ./pcib_if.h:173: error: type of formal parameter 3 is incomplete Clang also fails: In file included from /usr/src/sys/dev/acpica/acpi_hpet.c:58: =2E/pcib_if.h:165:61: error: declaration of 'enum pci_id_type' will not b= e visible outside of this function [-Werror,-Wvisibility] typedef int pcib_get_id_t(device_t pcib, device_t dev, enum pci_id_type type, ^ =2E/pcib_if.h:169:38: error: declaration of 'enum pci_id_type' will not b= e visible outside of this function [-Werror,-Wvisibility] enum pci_id_type type, uintptr_t *id) ^ =2E/pcib_if.h:169:50: error: variable has incomplete type 'enum pci_id_ty= pe' enum pci_id_type type, uintptr_t *id) ^ =2E/pcib_if.h:169:38: note: forward declaration of 'enum pci_id_type' enum pci_id_type type, uintptr_t *id) ^ 3 errors generated. Jung-uk Kim --gkT1gpbFKCewVB3FHhdWldx0PuEhlWnwK-- --dbepT12CGabjDgX7GV0qt71I7DPxJbh8V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXM6kjAAoJEHyflib82/FGxisH/2UnSReEe24q8QZG+/dJlwru rc58uTPMwwOkMMSGSHDwzEgCbKsSLSXd8tQZZkgcdYGuVcqus8GovjAqG//aDl6b ADugixcHnhHLJjAMyJvNMEATJXwchVC4D24wHfmejmXdhI7ufxrVsxJHvra0VxBM 8BqdZphHBhsLnjec+rGNf+jC3/uaDHM0tpY2Dy1YS4MZno33vVrxdPUtzj0SuJvH y6IoSuTXYJmwAK++4h4jaOjm2wtddGnfq6Q3UkiYj7MYUvUuj5Gg40NXt8ZuRrFG lb8ahH1K4VM9crBruXinHNFIoBw/La0k6Ach7YmLPdjIoLWtsj0gi6bLYEAu5xw= =NVao -----END PGP SIGNATURE----- --dbepT12CGabjDgX7GV0qt71I7DPxJbh8V--