From owner-freebsd-ports-bugs@FreeBSD.ORG  Fri Nov 15 23:10:03 2013
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5A15FE69
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri, 15 Nov 2013 23:10:03 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2E9872AEA
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Fri, 15 Nov 2013 23:10:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAFNA1MF092781
 for <freebsd-ports-bugs@freefall.freebsd.org>; Fri, 15 Nov 2013 23:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAFNA1EJ092780;
 Fri, 15 Nov 2013 23:10:01 GMT (envelope-from gnats)
Date: Fri, 15 Nov 2013 23:10:01 GMT
Message-Id: <201311152310.rAFNA1EJ092780@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Alex Samorukov <samm@os2.kiev.ua>
Subject: Re: ports/181836: Port sysutils/smartmontools brocken for scsi discs
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
Reply-To: Alex Samorukov <samm@os2.kiev.ua>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Nov 2013 23:10:03 -0000

The following reply was made to PR ports/181836; it has been noted by GNATS.

From: Alex Samorukov <samm@os2.kiev.ua>
To: bug-followup@FreeBSD.org, Meyser@xenet.de
Cc:  
Subject: Re: ports/181836: Port sysutils/smartmontools brocken for scsi discs
Date: Sat, 16 Nov 2013 00:07:25 +0100

 This is a multi-part message in MIME format.
 --------------030907090406080100010904
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 I was able to catch this bug and [probably] fix it. Could you please try 
 this patch (or latest svn version) and tell me if it works for you?
 
 
 
 --------------030907090406080100010904
 Content-Type: text/x-patch;
  name="fix_freebsd.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="fix_freebsd.diff"
 
 Index: os_freebsd.cpp
 ===================================================================
 --- os_freebsd.cpp	(revision 3857)
 +++ os_freebsd.cpp	(revision 3858)
 @@ -445,7 +445,8 @@
    }
  
    if ((ccb.ccb_h.status & CAM_STATUS_MASK) != CAM_REQ_CMP) {
 -    cam_error_print(m_camdev, &ccb, CAM_ESF_ALL, CAM_EPF_ALL, stderr);
 +    if(scsi_debugmode > 0)
 +      cam_error_print(m_camdev, &ccb, CAM_ESF_ALL, CAM_EPF_ALL, stderr);
      set_err(EIO);
      return -1;
    }
 @@ -997,13 +998,15 @@
  
    if (cam_send_ccb(m_camdev,ccb) < 0) {
      warn("error sending SCSI ccb");
 -    cam_error_print(m_camdev,ccb,CAM_ESF_ALL,CAM_EPF_ALL,stderr);
 +    if (report > 0)
 +      cam_error_print(m_camdev,ccb,CAM_ESF_ALL,CAM_EPF_ALL,stderr);
      cam_freeccb(ccb);
      return -EIO;
    }
  
 -  if (((ccb->ccb_h.status & CAM_STATUS_MASK) != CAM_REQ_CMP) && ((ccb->ccb_h.status & CAM_STATUS_MASK) != CAM_SCSI_STATUS_ERROR)) {
 -    cam_error_print(m_camdev,ccb,CAM_ESF_ALL,CAM_EPF_ALL,stderr);
 +  if (((ccb->ccb_h.status & CAM_STATUS_MASK) != CAM_REQ_CMP) && ((ccb->ccb_h.status & CAM_STATUS_MASK) == CAM_SCSI_STATUS_ERROR)) {
 +    if(report > 0)
 +      cam_error_print(m_camdev,ccb,CAM_ESF_ALL,CAM_EPF_ALL,stderr);
      cam_freeccb(ccb);
      return -EIO;
    }
 
 --------------030907090406080100010904--