From owner-cvs-usrsbin Tue Feb 7 12:30:50 1995 Return-Path: cvs-usrsbin-owner Received: (from root@localhost) by freefall.cdrom.com (8.6.9/8.6.6) id MAA07024 for cvs-usrsbin-outgoing; Tue, 7 Feb 1995 12:30:50 -0800 Received: from sneezy.sri.com (sneezy.sri.com [128.18.40.6]) by freefall.cdrom.com (8.6.9/8.6.6) with SMTP id MAA07017; Tue, 7 Feb 1995 12:30:47 -0800 Received: from rocky.sri.MT.net (sri.MT.net) by sneezy.sri.com (4.1/SMI-4.1) id AA05766; Tue, 7 Feb 95 12:30:39 PST Received: by rocky.sri.MT.net (4.1/SMI-4.1) id AA02093; Tue, 7 Feb 95 13:32:14 MST Message-Id: <9502072032.AA02093@rocky.sri.MT.net> From: Nate Williams Date: Tue, 7 Feb 1995 13:32:14 -0700 In-Reply-To: Garrett Wollman "Re: cvs commit: src/usr.sbin/lsdev i386.c" (Feb 7, 14:34) Reply-To: Nate Williams X-Mailer: Mail User's Shell (7.2.5 10/14/92) To: Garrett Wollman , Bruce Evans Subject: Re: cvs commit: src/usr.sbin/lsdev i386.c Cc: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com Sender: cvs-usrsbin-owner@freebsd.org Precedence: bulk > > I asked Stefan to think about including less goop in . > > This resulted in the above commit. But the above commit was wrong because > > PCI_INTERNAL_LEN is not used directly by i386.c; it is apparently required > > for to be self-contained. This was fixed before you > > looked at the sources. > > Hmmm. I don't belong to that religion that says that no header files > should ever include other header files and it's the responsibility for > the poor programmer to make sure that every program includes every > header file in the universe directly in case it's needed somewhere. I agree, but there is a happy medium. I've seen *way* too many problems with programs that include every other header file so that the poor programmer doesn't have to include but one header, and it *WILL* cause that poor programmer no end of grief. Nate