From owner-svn-src-head@FreeBSD.ORG  Mon Jun 18 09:36:52 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 675FB1065670;
	Mon, 18 Jun 2012 09:36:52 +0000 (UTC) (envelope-from gprspb@mail.ru)
Received: from fallback3.mail.ru (fallback3.mail.ru [94.100.176.58])
	by mx1.freebsd.org (Postfix) with ESMTP id 098098FC14;
	Mon, 18 Jun 2012 09:36:52 +0000 (UTC)
Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154])
	by fallback3.mail.ru (mPOP.Fallback_MX) with ESMTP id 9EA41B317B1E;
	Mon, 18 Jun 2012 13:35:33 +0400 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru;
	s=mail; 
	h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date;
	bh=rYvQt8vuDfCiziI29s7P13gtpLdzPu4OeHJ2jWwVAUU=; 
	b=DIaqfur5ORvJrmYTIqG8wcgvbfmJ1fU39zcIzDb+HX1b2btDH+QAJcI4u3h1rLqG2X1msSkjH850MAj5tXfzu644lVDlV6mXytQCoyIiY8/1GkF4eD1GRONiAQGK9Ezp;
Received: from [93.185.182.46] (port=27508 helo=gpr.nnz-home.ru)
	by smtp17.mail.ru with esmtpa (envelope-from <gprspb@mail.ru>)
	id 1SgYMo-000068-5k; Mon, 18 Jun 2012 13:35:26 +0400
Received: from gpr by gpr.nnz-home.ru with local (Exim 4.77 (FreeBSD))
	(envelope-from <gprspb@mail.ru>)
	id 1SgYLz-0000I6-Ad; Mon, 18 Jun 2012 13:34:35 +0400
Date: Mon, 18 Jun 2012 13:34:35 +0400
From: Gennady Proskurin <gprspb@mail.ru>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Message-ID: <20120618093435.GA1017@gpr.nnz-home.ru>
References: <201206180754.q5I7sBoQ063448@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201206180754.q5I7sBoQ063448@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam: Not detected
X-Mras: Ok
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r237223 - head/sys/dev/fb
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2012 09:36:52 -0000

On Mon, Jun 18, 2012 at 07:54:11AM +0000, Poul-Henning Kamp wrote:
> Author: phk
> Date: Mon Jun 18 07:54:10 2012
> New Revision: 237223
> URL: http://svn.freebsd.org/changeset/base/237223
> 
> Log:
>   Fix the previous commit to only copy the data we were asked to and not
>   twice as much.
>   
>   Spotted by:	Taku YAMAMOTO
> 
> Modified:
>   head/sys/dev/fb/fbreg.h
> 
> Modified: head/sys/dev/fb/fbreg.h
> ==============================================================================
> --- head/sys/dev/fb/fbreg.h	Mon Jun 18 07:43:23 2012	(r237222)
> +++ head/sys/dev/fb/fbreg.h	Mon Jun 18 07:54:10 2012	(r237223)
> @@ -39,6 +39,7 @@
>  static __inline void
>  copyw(uint16_t *src, uint16_t *dst, size_t size)
>  {
> +	size >>= 1;
>  	while (size--)
>  		*dst++ = *src++;
>  }

If size is odd, this does not copy the last byte. Not sure, whether this is intended.