From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:24 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F228216A4CE for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D61FE43D45 for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eNFn086944 for ; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eNcc086943; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:23 GMT Resent-Message-Id: <200409120240.i8C2eNcc086943@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24AD816A4CE for ; Sun, 12 Sep 2004 02:37:37 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id E620E43D48 for ; Sun, 12 Sep 2004 02:37:35 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bYow007095 for ; Sun, 12 Sep 2004 04:37:34 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bXEB007094 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:33 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2bXEB007094@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:33 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71617: [PATCH] cleanup of the usr.sbin/ypserv code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:24 -0000 >Number: 71617 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/ypserv code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:23 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/ypserv/yp_main.c,v 1.26 2003/05/03 21:06:42 obrien usr.sbin/ypserv/yp_dnslookup.c,v 1.24 2003/05/03 21:06:42 obrien >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/ypserv/yp_dnslookup.c:347: warning: unused variable `retrybuf' usr.sbin/ypserv/yp_dnslookup.c:454: warning: int format, long unsigned int arg (arg 2) usr.sbin/ypserv/yp_dnslookup.c:518: warning: int format, long unsigned int arg (arg 2) usr.sbin/ypserv/yp_main.c:109: warning: unused variable `forked' >How-To-Repeat: N/A >Fix: *** usr.sbin/ypserv/yp_dnslookup.c.ORIG Thu May 29 19:34:29 2003 --- usr.sbin/ypserv/yp_dnslookup.c Sun Sep 5 19:08:30 2004 *************** *** 344,350 **** { register struct circleq_dnsentry *q; char buf[sizeof(HEADER) + MAXPACKET]; - char retrybuf[MAXHOSTNAMELEN]; struct sockaddr_in sin; int rval; int len; --- 344,349 ---- *************** *** 451,457 **** pending++; if (debug) ! yp_error("queueing async DNS name lookup (%d)", q->id); yp_prune_dnsq(); return(YP_TRUE); --- 450,456 ---- pending++; if (debug) ! yp_error("queueing async DNS name lookup (%lu)", q->id); yp_prune_dnsq(); return(YP_TRUE); *************** *** 515,521 **** pending++; if (debug) ! yp_error("queueing async DNS address lookup (%d)", q->id); yp_prune_dnsq(); return(YP_TRUE); --- 514,520 ---- pending++; if (debug) ! yp_error("queueing async DNS address lookup (%lu)", q->id); yp_prune_dnsq(); return(YP_TRUE); *** usr.sbin/ypserv/yp_main.c.ORIG Thu May 29 19:34:29 2003 --- usr.sbin/ypserv/yp_main.c Sun Sep 5 19:09:31 2004 *************** *** 106,112 **** #else int readfds; #endif /* def FD_SETSIZE */ - extern int forked; int fd_setsize = _rpc_dtablesize(); struct timeval timeout; --- 106,111 ---- >Release-Note: >Audit-Trail: >Unformatted: