Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Oct 2005 20:43:41 +0200 (CEST)
From:      Dominique Goncalves <dominique.goncalves@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/88089: [PATCH] fix a bug when inserting a disk in sysutils/gnomebaker	
Message-ID:  <200510271843.j9RIhfwq057671@djdomics.sceen.net>
Resent-Message-ID: <200510271850.j9RIo6nO063825@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         88089
>Category:       ports
>Synopsis:       [PATCH] fix a bug when inserting a disk in sysutils/gnomebaker
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 27 18:50:06 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Dominique Goncalves
>Release:        FreeBSD 6.0-RC1 i386
>Organization:
djdomics.sceen.net	
>Environment:
System: FreeBSD djdomics.sceen.net 6.0-RC1 FreeBSD 6.0-RC1 #14: Sun Oct 16 13:29:45 CEST 2005 dom@venus:/usr/obj/usr/src/sys/VENUS i386


>Description:
	Fix a bug when inserting a disk.
	Reported and tested by: Danilo Augusto Vicente Lara daniloavl_at_terra.com.br
	Obtained from: gnomebaker cvs http://cvs.sourceforge.net/viewcvs.py/gnomebaker/gnomebaker/src/devices.c?r1=1.22&r2=1.23
	
>How-To-Repeat:
	Insert a disk, click ok and it continues to ask about the cd on drive. 

>Fix:

	Patch from gnomebaker cvs of src/devices.c revision 1.23

--- gnomebaker_update_p2.patch begins here ---
diff -ruN gnomebaker.orig/Makefile gnomebaker/Makefile
--- gnomebaker.orig/Makefile	Thu Oct 27 19:33:54 2005
+++ gnomebaker/Makefile	Thu Oct 27 19:34:52 2005
@@ -6,7 +6,7 @@
 
 PORTNAME=		gnomebaker
 PORTVERSION=		0.5.0
-PORTREVISION=		1
+PORTREVISION=		2	
 CATEGORIES=		sysutils gnome
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	gnomebaker
diff -ruN gnomebaker.orig/files/patch-src-devices.c gnomebaker/files/patch-src-devices.c
--- gnomebaker.orig/files/patch-src-devices.c	Thu Jan  1 01:00:00 1970
+++ gnomebaker/files/patch-src-devices.c	Wed Oct 26 22:16:48 2005
@@ -0,0 +1,12 @@
+--- src/devices.c.orig	Wed Oct 26 22:12:18 2005
++++ src/devices.c	Wed Oct 26 22:12:41 2005
+@@ -779,7 +779,8 @@
+     gchar* devicename = devices_get_device_config(devicekey, GB_DEVICE_NAME_LABEL);
+     gchar* message = g_strdup_printf(_("Please insert a disk into the %s"), devicename);    
+     gint ret = GTK_RESPONSE_OK;
+-    while(!devices_is_disk_inserted(devicekey) && (ret == GTK_RESPONSE_OK))
++    /* while(!devices_is_disk_inserted(devicekey) && (ret == GTK_RESPONSE_OK)) */
++    if(!devices_is_disk_inserted(devicekey))
+     {
+         devices_eject_disk(devicekey);
+         ret = gnomebaker_show_msg_dlg(parent, GTK_MESSAGE_INFO, 
--- gnomebaker_update_p2.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510271843.j9RIhfwq057671>