From owner-freebsd-arch Thu Mar 22 16:42:39 2001 Delivered-To: freebsd-arch@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id C270F37B71F for ; Thu, 22 Mar 2001 16:42:35 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f2N0gBG91278; Thu, 22 Mar 2001 16:42:11 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Thu, 22 Mar 2001 16:42:03 -0800 (PST) From: John Baldwin To: Matthew Jacob Subject: Re: Critical Regions Round II Cc: arch@FreeBSD.org Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 22-Mar-01 Matthew Jacob wrote: >> Hrm, is a ldq any different from a ldl to the alpha? > > Umm... yup... 8 bytes instead of 4... I meant more in terms of speed, sorry. :) I knew the 8 vs. 4 bit. :) >> If ldq is faster I could >> make it be a register_t (and thus a __int64_t). I'll probably change it to >> register_t on x86 and ia64 as it simply holds the saved value of a register >> (eflags on x86, psr on ia64). > > I don't think the speed is an issue either way. Ok, then I'll use register_t since the IPL is part of the process status register and since it's put in a0 before the PAL call.. >> > What's wrong with alpha having >> > >> > disable_intr() calls MD/platform function that disables >> > mainbridge >> ints >> > enable_intr() calls MD/platform function that enables mainbridge ints >> > >> > I believe that this actually is possible. >> >> That's fine, however, with this change, disable/enable_intr() are actually >> called in very few places. Mostly in trap() on x86 due to hacks to work >> around >> Cyrix bugs, and in configure(). Everything else uses critical_*. >> >> Well, the joy driver needs fixing (it should use critical_*) as does the >> bktr >> driver. The x86 pcvt driver is also obnoxious, but its x86 specific, and >> the >> pc98 spkr and dma drivers should be using critical_* so that they work in a >> nested fashion. Hmm, and x86 profiling, though again, that can use >> critical_*. >> Kernel x86 profiling with SMP is broken in lots of interesting ways. > > > Let's put it this way...if I have to solve what appear to be obscure bugs by > disabling interrupts in the alpha MD code somewhere, I'll instantiate such a > function (again) if it's no longer there. Ok. Or you could always just call alpha_pal_swpipl(). :) -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message