From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jan 14 20:00:33 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61BB21065676 for ; Sat, 14 Jan 2012 20:00:33 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3D5AF8FC14 for ; Sat, 14 Jan 2012 20:00:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0EK0QOs003093 for ; Sat, 14 Jan 2012 20:00:26 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0EK0Q0W003092; Sat, 14 Jan 2012 20:00:26 GMT (envelope-from gnats) Resent-Date: Sat, 14 Jan 2012 20:00:26 GMT Resent-Message-Id: <201201142000.q0EK0Q0W003092@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Adam Weinberger Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D98D106568B for ; Sat, 14 Jan 2012 19:53:08 +0000 (UTC) (envelope-from adamw@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1DD3F8FC22 for ; Sat, 14 Jan 2012 19:53:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0EJr83s002596 for ; Sat, 14 Jan 2012 19:53:08 GMT (envelope-from adamw@freefall.freebsd.org) Received: (from adamw@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0EJr7X0002595; Sat, 14 Jan 2012 19:53:07 GMT (envelope-from adamw) Message-Id: <201201141953.q0EJr7X0002595@freefall.freebsd.org> Date: Sat, 14 Jan 2012 19:53:07 GMT From: Adam Weinberger To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/164129: editors/vim is unable to use the gnome2 interface X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Adam Weinberger List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 20:00:33 -0000 >Number: 164129 >Category: ports >Synopsis: editors/vim is unable to use the gnome2 interface >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jan 14 20:00:25 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Adam Weinberger >Release: FreeBSD 8.2-STABLE i386 >Organization: >Environment: System: FreeBSD freefall.freebsd.org 8.2-STABLE FreeBSD 8.2-STABLE #5 r227907: Wed Nov 23 21:55:50 UTC 2011 simon@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386 >Description: Due to two issues, the gnome2 interface in vim cannot be selected. The first reason is that WITH_GTK2 is set if nothing else is chosen, but that check looks for WITH_GNOME, instead of WITH_GNOME2 as defined by OPTIONS. The second reason is a conditional in the WITH_GNOME2 logic that I'm not really sure of the reason behind. The conditional only allows the gnome2 interface if WITH_GNOME2 is set to "yes" or "1", though bsd.options.mk sets the variable to "true". The attached patch resolves both these issues. Also, David I can't help but notice that vim hasn't been updated in almost half a year. If this is unintentional due to time constraints, I'd be happy to maintain the port for a while if you'd like. If this is intentional and none of the nearly 300 additional patches have sounded appealing, please forgive any insinuation otherwise. >How-To-Repeat: >Fix: --- vim.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/editors/vim/Makefile,v retrieving revision 1.386 diff -u -d -p -r1.386 Makefile --- Makefile 20 Jun 2011 17:40:31 -0000 1.386 +++ Makefile 14 Jan 2012 19:42:53 -0000 @@ -13,7 +13,7 @@ PORTNAME?= vim PATCHLEVEL= 121 PORTVERSION= 7.3.${PATCHLEVEL} RELEASE= vim-${PORTVERSION:C/\.[0-9a-z]*$//} -PORTREVISION?= 0 +PORTREVISION?= 1 CATEGORIES?= editors MASTER_SITES= ${MASTER_SITE_VIM} DISTFILES= ${RELEASE}${EXTRACT_SUFX} @@ -135,7 +135,7 @@ MAKE_ARGS+= CONF_OPT_TCL="--enable-tclin . if !defined(WITHOUT_X11) # for now default the GUI to the GTK+ one -. if !defined(WITH_X11_ONLY) && !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2) +. if !defined(WITH_X11_ONLY) && !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME2) && !defined(WITH_GTK2) WITH_GTK2= yes . endif @@ -147,14 +147,11 @@ MAKE_ARGS+= CONF_OPT_GUI="--enable-gui=g MAKE_ARGS+= X_LIBS="$(X_LIBS) -lXt" USE_XORG+= xt . elif defined(WITH_GNOME2) -. if ${WITH_GNOME2:Mlibgnomeui}!="" || ${WITH_GNOME2}=="yes" || \ - ${WITH_GNOME2}=="1" USE_GNOME= libgnomeui PKGNAMESUFFIX= -gnome2 MAKE_ARGS+= CONF_OPT_GUI="--enable-gui=gnome2" ${I18N} MAKE_ARGS+= X_LIBS="$(X_LIBS) -lXt" USE_XORG+= xt -. endif . elif defined(WITH_MOTIF) USE_MOTIF= yes MAKE_ARGS+= CONF_OPT_GUI="--enable-gui=motif --with-motif-lib=\"${MOTIFLIB}\"" MOTIFHOME=${LOCALBASE} ${I18N} --- vim.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: