Date: Wed, 20 Dec 2017 13:44:54 -0700 From: Warner Losh <imp@bsdimp.com> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327037 - head/sys/dev/acpica Message-ID: <CANCZdfpX76CXg28bX%2BV3ESseL%2BFPD_sTPvNnH05p-AaDpLXfsA@mail.gmail.com> In-Reply-To: <201712202033.vBKKXdbS040801@slippy.cwsent.com> References: <imp@FreeBSD.org> <201712201914.vBKJEG68087359@repo.freebsd.org> <201712202033.vBKKXdbS040801@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 20, 2017 1:33 PM, "Cy Schubert" <Cy.Schubert@komquats.com> wrote: In message <201712201914.vBKJEG68087359@repo.freebsd.org>, Warner Losh writes: > Author: imp > Date: Wed Dec 20 19:14:16 2017 > New Revision: 327037 > URL: https://svnweb.freebsd.org/changeset/base/327037 > > Log: > Simplify the code a bit. > > Replace clumsy for(;;) { if (foo) break; ...} with simpler > while (!foo) { ... }. > > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D13546 > > Modified: > head/sys/dev/acpica/acpi.c > > Modified: head/sys/dev/acpica/acpi.c > ============================================================ ================= > = > --- head/sys/dev/acpica/acpi.c Wed Dec 20 19:14:11 2017 (r32703 > 6) > +++ head/sys/dev/acpica/acpi.c Wed Dec 20 19:14:16 2017 (r32703 > 7) > @@ -1014,10 +1014,7 @@ acpi_hint_device_unit(device_t acdev, device_t child, > * name to see if one's resources are a subset of this device. > */ > line = 0; > - for (;;) { > - if (resource_find_dev(&line, name, &unit, "at", NULL) != 0) > - break; > - > + while (resource_find_dev(&line, name, &unit, "at", NULL) == 0) { > /* Must have an "at" for acpi or isa. */ > resource_string_value(name, unit, "at", &s); > if (!(strcmp(s, "acpi0") == 0 || strcmp(s, "acpi") == 0 || > Would it make sense we upline this to reduce future MFV diffs? No. This is 100% FreeBSD code. Warner -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpX76CXg28bX%2BV3ESseL%2BFPD_sTPvNnH05p-AaDpLXfsA>