From owner-svn-src-all@freebsd.org Thu May 5 02:05:11 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63D39B2DA45 for ; Thu, 5 May 2016 02:05:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E09711B9 for ; Thu, 5 May 2016 02:05:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22d.google.com with SMTP id d62so72410055iof.2 for ; Wed, 04 May 2016 19:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=25UyAnw073PFGAFZG5C/fdb/HIEEZY3aMt5c/33DU5I=; b=DwtCeOdy/a5CSZW4Yr/wVTxf7Tdd6Iu9h2r9PWnyp6HYqKO6Ira8I7ZQCJ0GV+TE4V CtriLx4WNFRyQ3B6YV+LGr85TSBZYj5ZROec1MLFVFYDZboV/UnYC2KXXaokqotERPyI 66O6PJn/EMfs82H1M7R3Ald7rjzYAM6XQzYcy1+q3FbjleW9rZtoJiUnnYjCmKPojJV8 xoVLgvrhKKQ9/FRUXtETmnw3I8Chjc02rXehRVU/tLJY8UCfuEC34T3eZQPEnbTDAJ1X cXkYF9W+0WlQkCdboTHWoTlF8AfVbQAv3ycZsHgEk3tozDuysLVDpK630K9FxYOB5lZl FHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=25UyAnw073PFGAFZG5C/fdb/HIEEZY3aMt5c/33DU5I=; b=AlmpAr3huEiMZsrDTTFe3bgJCQEDs/WT8p4ZspsFH73EQIUDpLy+jM2JS436egO4q7 O0a1R+zAZfrHBVSSi9SD+5VPW7Z7+QU33Ev1bewkAjVDTvgx7FXndnmfHbrBe/Hf7t1B nlCIm31gvBVhpPr21dTPelpHQyPnDuaZZ+SaWtk1G5HI3WCvH8tFXTF7Ae3ZaJYpbsfk eLwU7c+rZVih4JSJMbo91KOvpwOiiOg7eee0tbK+hxuLZKRVEbnr4rqyvzBsM0hCEdPg XRF2ocm4htfI1AEdMtTxYYVDTzLJNNqXMxCDbrtR9MGdZed8rQ2zXjq5HrPtWD7kG7mY mdZQ== X-Gm-Message-State: AOPr4FU65PeD9HpqFapOcvJ6hLYGXiVao+FdBQKyz3EByNNmE2/UOP5fa0QsRb8cZlo+Op3iUSzpRkq1WYjRCg== MIME-Version: 1.0 X-Received: by 10.107.40.9 with SMTP id o9mr13681983ioo.183.1462413910413; Wed, 04 May 2016 19:05:10 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.79.75.68 with HTTP; Wed, 4 May 2016 19:05:10 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <07EA9409-1155-4D47-BD81-D03C675A35CE@gmail.com> References: <201605042100.u44L0fdS023680@repo.freebsd.org> <3C136183-85D6-4047-8F2B-FB1B6C310AFF@gmail.com> <20160505003135.GH1369@FreeBSD.org> <07EA9409-1155-4D47-BD81-D03C675A35CE@gmail.com> Date: Wed, 4 May 2016 20:05:10 -0600 X-Google-Sender-Auth: s76Zzpd0Z582p1x9PC5017o2zhc Message-ID: Subject: Re: svn commit: r299086 - head From: Warner Losh To: "Ngie Cooper (yaneurabeya)" Cc: Gleb Smirnoff , Garrett Cooper , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 02:05:11 -0000 BTW, why is this a new NO_XXXX thing? It should be MK_XXXX instead... Warner On Wed, May 4, 2016 at 6:47 PM, Ngie Cooper (yaneurabeya) < yaneurabeya@gmail.com> wrote: > > > On May 4, 2016, at 17:31, Gleb Smirnoff wrote: > > > > On Wed, May 04, 2016 at 02:06:33PM -0700, Ngie Cooper (yaneurabeya) > wrote: > > N> > > N> > On May 4, 2016, at 14:00, Garrett Cooper wrote: > > N> > > > N> > Author: ngie > > N> > Date: Wed May 4 21:00:41 2016 > > N> > New Revision: 299086 > > N> > URL: https://svnweb.freebsd.org/changeset/base/299086 > > N> > > > N> > Log: > > N> > Default NO_INSTALLEXTRAKERNELS to "no" to unbreak the build > > N> > > > N> > MFC after: soon (was insta-MFCed -_-..) > > N> > Pointyhat to: glebius > > N> > Sponsored by: EMC / Isilon Storage Division > > N> > > > N> > Modified: > > N> > head/Makefile.inc1 > > > > Defaulting it to "no" you changed the behaviour backwards, which is > > wrong. > > Agreed. That=E2=80=99s why I inverted it back to =E2=80=9Cyes=E2=80=9D in= r299088. > > > N> This broke for me on 11.0-CURRENT because I use: > > N> > > N> KERNCONFS=3D GENERIC GENERIC-NODEBUG > > N> > > N> and use installkernel with INSTKERNNAME. > > > > That's quite specific setup. Probably NO_INSTALLEXTRAKERNELS should > > be played with conditionally. > > It=E2=80=99s not an uncommon setup though. I have used it on all my CURRE= NT > machines for some time because I might want to be able to use INVARIANTS > kernels sometimes when doing kernel changes, and boot !INVARIANTS kernels > all of the time. > > I chose "?=3D yes=E2=80=9D because it=E2=80=99s better syntactic sugar th= an > `defined(NO_INSTALLEXTRAKERNELS) && ${NO_INSTALLKERNELS} !=3D =E2=80=9Cye= s=E2=80=9D` and it > works with pre-bmake (the other idiom that bmake allows that would work > here=E2=80=A6 although with more duplicity is `:Uyes`, which would break > installkernel on FreeBSD 9 machines or with fmake as the system make). > > Thanks! > -Ngie >