From owner-cvs-all@FreeBSD.ORG Sun Oct 26 12:44:58 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0CE916A4B3; Sun, 26 Oct 2003 12:44:58 -0800 (PST) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B10743F75; Sun, 26 Oct 2003 12:44:57 -0800 (PST) (envelope-from alc@cs.rice.edu) Received: from localhost (localhost [127.0.0.1]) by cs.rice.edu (Postfix) with ESMTP id D1D404AA29; Sun, 26 Oct 2003 14:44:56 -0600 (CST) Received: from cs.rice.edu ([127.0.0.1]) by localhost (cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 08355-01-3; Sun, 26 Oct 2003 14:44:55 -0600 (CST) Received: by cs.rice.edu (Postfix, from userid 19572) id 650664AA09; Sun, 26 Oct 2003 14:44:55 -0600 (CST) Date: Sun, 26 Oct 2003 14:44:55 -0600 From: Alan Cox To: Jeff Roberson Message-ID: <20031026204455.GC20658@cs.rice.edu> References: <20031026201944.GA20658@cs.rice.edu> <20031026153051.X43805-100000@mail.chesapeake.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031026153051.X43805-100000@mail.chesapeake.net> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavis-20030616-p5 at rice.edu cc: Alan Cox cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Oct 2003 20:44:58 -0000 On Sun, Oct 26, 2003 at 03:34:05PM -0500, Jeff Roberson wrote: > On Sun, 26 Oct 2003, Alan Cox wrote: > > > With this change, you may see: > > > > lock order reversal > > 1st 0xc24aab90 vm object (vm object) @ vm/swap_pager.c:1319 > > 2nd 0xc070f180 swap_pager swhash (swap_pager swhash) @ vm/swap_pager.c:1832 > > 3rd 0xc1036b90 vm object (vm object) @ vm/uma_core.c:876 > > > > This is also a false positive. The only vm object that is locked > > after acquiring the "swap_pager swhash" mutex is one used internally > > in UMA. We will never acquire this vm object's mutex followed by > > the "swap_pager swhash" mutex. > > Does the swap_zone really need a backing object? This is just so the > operation wont fail for lack of kva, right? Is this really necessary > here? I thought we did it before so that we could allocate at interrupt > time, since pages could be allocated, but kva could not. I doubt this > code runs at real interrupt time anymore. > What would you propose? I believe switching to page_alloc() would also produce a false LOR warning. Regards, Alan > > > > > Regards, > > Alan > > > > On Sun, Oct 26, 2003 at 11:55:35AM -0800, Alan Cox wrote: > > > alc 2003/10/26 11:55:35 PST > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/vm swap_pager.c > > > Log: > > > - Introduce and use a mutex synchronizing access to the swblock hash table. > > > > > > Revision Changes Path > > > 1.234 +20 -4 src/sys/vm/swap_pager.c > >