From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 20 13:50:01 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65EEE16A41B for ; Sat, 20 Oct 2007 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4AA6513C469 for ; Sat, 20 Oct 2007 13:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KDo1O7029152 for ; Sat, 20 Oct 2007 13:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9KDo1Y6029151; Sat, 20 Oct 2007 13:50:01 GMT (envelope-from gnats) Resent-Date: Sat, 20 Oct 2007 13:50:01 GMT Resent-Message-Id: <200710201350.l9KDo1Y6029151@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, bf Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AD88216A41A for ; Sat, 20 Oct 2007 13:45:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A4CE513C448 for ; Sat, 20 Oct 2007 13:45:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KDim0L047671 for ; Sat, 20 Oct 2007 13:44:48 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id l9KDimTZ047670; Sat, 20 Oct 2007 13:44:48 GMT (envelope-from nobody) Message-Id: <200710201344.l9KDimTZ047670@www.freebsd.org> Date: Sat, 20 Oct 2007 13:44:48 GMT From: bf To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/117360: [PATCH]multimedia/gxine: respect CFLAGS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 13:50:01 -0000 >Number: 117360 >Category: ports >Synopsis: [PATCH]multimedia/gxine: respect CFLAGS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 20 13:50:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: bf >Release: 6.2-Stable i386 >Organization: - >Environment: >Description: I think it would be best to respect CFLAGS. If some flags are problematic, a note recommending a certain set and warning against others could be added, instead of forcing the users to adopt a default set or to make a custom build: diff -ruN gxine.orig/Makefile gxine/Makefile --- gxine.orig/Makefile Sat Oct 20 04:48:31 2007 +++ gxine/Makefile Sat Oct 20 04:49:30 2007 @@ -25,7 +25,7 @@ LDFLAGS="-L${LOCALBASE}/lib -I${X11BASE}/lib" CONFIGURE_ARGS+=--x-includes=${X11BASE}/include \ --x-libraries=${X11BASE}/lib -CFLAGS= -O2 -fno-strict-aliasing -pipe +CFLAGS?= -O2 -fno-strict-aliasing -pipe INSTALLS_ICONS= yes MANLANG= "" de >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: