From nobody Thu May 28 02:46:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQrTb1MLwz6g6f9 for ; Thu, 28 May 2026 02:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQrTZ5m2jz47tD for ; Thu, 28 May 2026 02:46:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779936370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yBSp7DaX8ESwlwJLGWYffwvc9hbWAJmoHwFEVghGSgo=; b=w4PqTLpVZsrVXmJfDddUnyEM8coAno63IAlYumDKWgAjWqzhLMO20OF2kpq6YJCQeTa9fC gdVLTeT2Ps5dcBYn1P6WrGoR41+ZWJW0mkvE+fq7vHuVjuWu6rjbnA5aU33uncrD4qibZj zH5eLNJ6wGTM+NQSCaxycvGUUKQ7iKUKKMUo34DF6kKoDvNxdj9Gcahp/KoQv/pDQzrBNt +628K97v8F5tKTt2MMglLHO9etYP+iJBWCd5qd2qww6C9To1fgYyJN3gQkknYppxbHtHD8 RpfvSknSd/Yal10X8Xm67XsZgtHN0BcGuhBCuSjEE/uxluSN758QbEm9pNLfww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779936370; a=rsa-sha256; cv=none; b=YfxtAoHx60oHi5G3T9b6F6slGSZifVYiut7zQo5TcMlheIB3SsfU2tXL6xJ7/kEKgu82Sy f0cROmgmpqzrMbgUQ1JD+fe4UZzITURBTHk6/5NNAoAF6D7ApCFgueMVnz+pUMo5z4UWby 2J4t1GxoTYPLVG5RUiKTyEEf9n8WjXUbHqnHmULiUTrJQCOvnKj7oY6yKOa4SzeBkh6jUP a17VmxwElXUU4I2ZeGq08uEHwCA9KiJl+HNkkMlFxv6xrp+mJNk9Qn4N92MkORZv3Tf0A0 n48mIU0nG4JosnjBxJHDTq81s5iwAUsFjZWQXvaUvGudnmnYaXSxIkQQtrQ8Og== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779936370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yBSp7DaX8ESwlwJLGWYffwvc9hbWAJmoHwFEVghGSgo=; b=Zjhi6k1jGzMo/f/arh/JchfGyFtyXZN5RYn063u+B2QwRmTL6PINcFhDMakO1Z6Z4fBwI8 ROGozqjHPl3CWHXxGVfq+CN6IZrQj6iVpbRhim3IuX23gm6wILKDcYUXVI+QipCtR6EC32 6wBFnfGRSzNFuBriulI8Y7rBhX/0871kCZFYrp2gr/7f2ruiOU/qmzbqzX/E6kxTKDuRG4 +lGEt44oATax6+dcRS7n3fEC8XPa1ag/yhv9SyddpCi3E/lIf4yg2sI1USVrYqM46e5W/j nBNW1uHV2cjUGO/UP4PGw8FHRko3WCYDzkW/nCYfjleBdVv9Mb8939jUc6gWkg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQrTZ4hZZzBpQ for ; Thu, 28 May 2026 02:46:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27816 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 28 May 2026 02:46:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 947dd1ca1297 - stable/15 - subr_uio.c: Remove a KASSERT() for large NFS server I/O List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 947dd1ca129787b93cca3bf390c3a34032a49ac9 Auto-Submitted: auto-generated Date: Thu, 28 May 2026 02:46:10 +0000 Message-Id: <6a17ac72.27816.5335c2a2@gitrepo.freebsd.org> The branch stable/15 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=947dd1ca129787b93cca3bf390c3a34032a49ac9 commit 947dd1ca129787b93cca3bf390c3a34032a49ac9 Author: Rick Macklem AuthorDate: 2026-05-14 22:17:55 +0000 Commit: Rick Macklem CommitDate: 2026-05-28 02:44:46 +0000 subr_uio.c: Remove a KASSERT() for large NFS server I/O When the NFS server is set to allow an I/O size greater than 1Mbyte (not allowed in FreeBSD's main yet), a KASSERT() in allocuio() can fail when: zfs_freebsd_write()->zfs_write()->zfs_uiocopy() ->cloneuio()->allocuio() is called for a large NFS server write. Since the userland API callers to allocuio() already check that the size does not exceed UIO_MAXIOV, there does not seem to be a need to a KASSERT() here. Removing the KASSERT() allows NFS server writes of greater than 1Mbyte to work, once the NFS code is patched to allow them. (cherry picked from commit 13d3bd165e225eec9af91b6e3361c2482931f95b) --- sys/kern/subr_uio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/kern/subr_uio.c b/sys/kern/subr_uio.c index 6ac932fb6690..fa5865fbe938 100644 --- a/sys/kern/subr_uio.c +++ b/sys/kern/subr_uio.c @@ -441,8 +441,6 @@ allocuio(u_int iovcnt) struct uio *uio; int iovlen; - KASSERT(iovcnt <= UIO_MAXIOV, - ("Requested %u iovecs exceed UIO_MAXIOV", iovcnt)); iovlen = iovcnt * sizeof(struct iovec); uio = malloc(iovlen + sizeof(*uio), M_IOV, M_WAITOK); uio->uio_iov = (struct iovec *)(uio + 1);