From owner-freebsd-hardware@FreeBSD.ORG Fri May 27 19:33:05 2011 Return-Path: Delivered-To: freebsd-hardware@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB0761065670; Fri, 27 May 2011 19:33:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id AAEA28FC18; Fri, 27 May 2011 19:33:04 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 60F0C46B45; Fri, 27 May 2011 15:33:04 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 005388A04F; Fri, 27 May 2011 15:33:04 -0400 (EDT) From: John Baldwin To: Mike Tancsa Date: Fri, 27 May 2011 15:33:03 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <20110521092037.GB3271@vpn.offrom.nl> <201105271200.12062.jhb@freebsd.org> <4DDFE56E.3000406@sentex.net> In-Reply-To: <4DDFE56E.3000406@sentex.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105271533.03445.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 27 May 2011 15:33:04 -0400 (EDT) Cc: Willy@offermans.rompen.nl, Marcel Moolenaar , freebsd-stable@freebsd.org, freebsd-hardware@freebsd.org Subject: Re: modem support MT9234ZPX-PCIE-NV X-BeenThere: freebsd-hardware@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: General discussion of FreeBSD hardware List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2011 19:33:05 -0000 On Friday, May 27, 2011 1:54:54 pm Mike Tancsa wrote: > On 5/27/2011 12:00 PM, John Baldwin wrote: > >> > >> uart2@pci0:5:0:0: class=0x070002 card=0x20282205 chip=0x015213a8 > >> rev=0x02 hdr=0x00 > >> vendor = 'Exar Corp.' > >> device = 'XR17C/D152 Dual PCI UART' > >> class = simple comms > >> subclass = UART > > > > Possibly. Did you try adding it via puc instead? > > Yes, same result. But I am not sure what values to plugin for some of > the options. > > I tried this is uart > > 1(ich10)# diff -u uart_bus_pci.c.orig uart_bus_pci.c > --- uart_bus_pci.c.orig 2011-05-24 17:10:21.000000000 -0400 > +++ uart_bus_pci.c 2011-05-27 10:49:05.000000000 -0400 > @@ -110,6 +110,8 @@ > { 0x1415, 0x950b, 0xffff, 0, "Oxford Semiconductor OXCB950 Cardbus > 16950 UART", > 0x10, 16384000 }, > { 0x151f, 0x0000, 0xffff, 0, "TOPIC Semiconductor TP560 56k modem", 0x10 }, > +{ 0x13a8, 0x0152, 0x2205, 0x2028, "MultiTech MultiModem ZPX", 0x10, > + 8 * DEFAULT_RCLK }, > { 0x9710, 0x9835, 0x1000, 1, "NetMos NM9835 Serial Port", 0x10 }, > { 0x9710, 0x9865, 0xa000, 0x1000, "NetMos NM9865 Serial Port", 0x10 }, > { 0x9710, 0x9901, 0xa000, 0x1000, > 1(ich10)# > > Then I removed the entry from uart and added the following for pucdata.c > > > { 0x13a8, 0x0152, 0xffff, 0, > "Exar Multitech", > DEFAULT_RCLK * 8, > PUC_PORT_2S, 0x10, 0, -1, > }, > > But it does not seem to want to attach ? Actually, can you just try this: Index: pucdata.c =================================================================== --- pucdata.c (revision 222364) +++ pucdata.c (working copy) @@ -48,7 +48,6 @@ __FBSDID("$FreeBSD$"); #include static puc_config_f puc_config_amc; -static puc_config_f puc_config_cronyx; static puc_config_f puc_config_diva; static puc_config_f puc_config_icbook; static puc_config_f puc_config_quatech; @@ -548,11 +547,22 @@ const struct puc_cfg puc_pci_devices[] = { PUC_PORT_8S, 0x18, 0, 8, }, + { 0x13a8, 0x0152, 0xffff, 0, + "Exar XR17C/D152", + DEFAULT_RCLK * 8, + PUC_PORT_2S, 0x10, 0, 0x200, + }, + + { 0x13a8, 0x0154, 0xffff, 0, + "Exar XR17C154", + DEFAULT_RCLK * 8, + PUC_PORT_4S, 0x10, 0, 0x200, + }, + { 0x13a8, 0x0158, 0xffff, 0, - "Cronyx Omega2-PCI", + "Exar XR17C158", DEFAULT_RCLK * 8, - PUC_PORT_8S, 0x10, 0, -1, - .config_function = puc_config_cronyx + PUC_PORT_8S, 0x10, 0, 0x200, }, { 0x13a8, 0x0258, 0xffff, 0, @@ -1014,17 +1024,6 @@ puc_config_amc(struct puc_softc *sc, enum puc_cfg_ } static int -puc_config_cronyx(struct puc_softc *sc, enum puc_cfg_cmd cmd, int port, - intptr_t *res) -{ - if (cmd == PUC_CFG_GET_OFS) { - *res = port * 0x200; - return (0); - } - return (ENXIO); -} - -static int puc_config_diva(struct puc_softc *sc, enum puc_cfg_cmd cmd, int port, intptr_t *res) { -- John Baldwin