From owner-p4-projects@FreeBSD.ORG Tue Jan 20 23:33:04 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E0A2C1065673; Tue, 20 Jan 2009 23:33:03 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C271106566B for ; Tue, 20 Jan 2009 23:33:03 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8A82F8FC17 for ; Tue, 20 Jan 2009 23:33:03 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n0KNX3CR072287 for ; Tue, 20 Jan 2009 23:33:03 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n0KNX3iK072285 for perforce@freebsd.org; Tue, 20 Jan 2009 23:33:03 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Tue, 20 Jan 2009 23:33:03 GMT Message-Id: <200901202333.n0KNX3iK072285@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 156451 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 23:33:05 -0000 http://perforce.freebsd.org/chv.cgi?CH=156451 Change 156451 by rwatson@rwatson_freebsd_capabilities on 2009/01/20 23:32:12 If a capability-mode process manages to get into namei(), print a stack trace if KDB is compiled into the kernel. Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/kern/vfs_lookup.c#6 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/kern/vfs_lookup.c#6 (text+ko) ==== @@ -37,6 +37,7 @@ #include __FBSDID("$FreeBSD: src/sys/kern/vfs_lookup.c,v 1.117 2008/12/18 11:58:12 kib Exp $"); +#include "opt_kdb.h" #include "opt_ktrace.h" #include "opt_mac.h" @@ -54,6 +55,9 @@ #include #include #include +#ifdef KDB +#include +#endif #ifdef KTRACE #include #endif @@ -128,6 +132,14 @@ struct proc *p = td->td_proc; int vfslocked; +#ifdef KDB + if (td->td_ucred->cr_flags & CRED_FLAG_CAPMODE) { + printf("namei: pid %d proc %s performed namei in capability " + "mode\n", p->p_pid, p->p_comm); + kdb_backtrace(); + } +#endif + KASSERT((cnp->cn_flags & MPSAFE) != 0 || mtx_owned(&Giant) != 0, ("NOT MPSAFE and Giant not held")); ndp->ni_cnd.cn_cred = ndp->ni_cnd.cn_thread->td_ucred;