From owner-cvs-all@FreeBSD.ORG  Fri Oct 26 21:04:25 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 201AD16A418
	for <cvs-all@FreeBSD.org>; Fri, 26 Oct 2007 21:04:25 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with SMTP id A78B613C4BD
	for <cvs-all@FreeBSD.org>; Fri, 26 Oct 2007 21:04:24 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 13561 invoked by uid 399); 26 Oct 2007 21:04:23 -0000
Received: from localhost (HELO slave.dougb.net) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTP; 26 Oct 2007 21:04:23 -0000
X-Originating-IP: 127.0.0.1
Date: Fri, 26 Oct 2007 14:04:21 -0700 (PDT)
From: Doug Barton <dougb@FreeBSD.org>
To: Pav Lucistnik <pav@FreeBSD.org>
In-Reply-To: <200710261338.l9QDcLQ0028796@repoman.freebsd.org>
Message-ID: <alpine.BSF.0.9999.0710261403220.75470@qbhto.arg>
References: <200710261338.l9QDcLQ0028796@repoman.freebsd.org>
X-message-flag: Outlook -- Not just for spreading viruses anymore!
X-OpenPGP-Key-ID: 0xD5B2F0FB
Organization: http://www.FreeBSD.org/
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
Cc: Bruce Cran <bruce@cran.org.uk>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/ataidle Makefile
 ports/sysutils/ataidle/files ataidle.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2007 21:04:25 -0000

On Fri, 26 Oct 2007, Pav Lucistnik wrote:

> pav         2007-10-26 13:38:21 UTC
>
>  FreeBSD ports repository
>
>  Modified files:
>    sysutils/ataidle     Makefile
>    sysutils/ataidle/files ataidle.in
>  Log:
>  - Improve rc script
>
>  PR:             ports/117514  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=117514
>  Submitted by:   Bruce Cran <bruce@cran.org.uk> (maintainer)
>
>  Revision  Changes    Path
>  1.11      +1 -0      ports/sysutils/ataidle/Makefile
>  1.3       +28 -16    ports/sysutils/ataidle/files/ataidle.in
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/ataidle/Makefile.diff?&r1=1.10&r2=1.11&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/ataidle/files/ataidle.in.diff?&r1=1.2&r2=1.3&f=h

This is good work! The only thing I would change is to move the _start 
function above load_rc_config, but that's just a style issue. Thanks for 
taking the time to improve this.

Doug

-- 

     This .signature sanitized for your protection