From owner-freebsd-ports@freebsd.org  Wed Mar 16 17:58:02 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 28C37AD222D
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Wed, 16 Mar 2016 17:58:02 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 1A0CE1C5A
 for <freebsd-ports@freebsd.org>; Wed, 16 Mar 2016 17:58:02 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 15AE2AD222C; Wed, 16 Mar 2016 17:58:02 +0000 (UTC)
Delivered-To: ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15556AD222B
 for <ports@mailman.ysv.freebsd.org>; Wed, 16 Mar 2016 17:58:02 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id EC4B51C59
 for <ports@FreeBSD.org>; Wed, 16 Mar 2016 17:58:01 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u2GHvsbJ038871
 for <ports@FreeBSD.org>; Wed, 16 Mar 2016 10:57:58 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201603161757.u2GHvsbJ038871@gw.catspoiler.org>
Date: Wed, 16 Mar 2016 10:57:54 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: gnome-post-install ordering
To: ports@FreeBSD.org
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2016 17:58:02 -0000

I'm trying to debug why gtk-update-icon-cache isn't getting run when
the OpenOffice package is installed and ran into something that I don't
understand.

The Makefile contains INSTALLS_ICONS=yes, which has the side effect of
setting USES+=gnome, USE_GNOME+=gtk-update-icon-cache, and
_USES_install+=690:gnome-post-install, and that target is responsible
for parsing ${TMPPLIST} and invoking gtk-update-icon-cache as needed.
I do see gtk-update-icon-cache in the dependency list in +MANIFEST, so
it appears that INSTALLS_ICONS=yes is being detected.

It appears that things go wrong because I'm using the Makefile
post-install target to generate the plist.  If I look at bsd.port.mk, I
see that _STAGE_SEQ contains 700:post-install.  It looks to me like
gnome-post-install is getting run before the plist is generated, which
would explain why gnome-post-install isn't detecting any icons and not
invoking gtk-update-icon-cache.

Why is gnome-post-install earlier than post-install, which at least some
ports use to do plist generation?  Some ports do plist generation in
do-install, but that doesn't work if there are do-install option helpers
because those get run after the main do-install target.

There is the TARGET_ORDER_OVERRIDE knob, but it is very lightly used.