From owner-freebsd-current Mon Aug 5 7:54:20 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7E24C37B400 for ; Mon, 5 Aug 2002 07:54:12 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1250543E5E for ; Mon, 5 Aug 2002 07:54:12 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 25793 invoked from network); 5 Aug 2002 14:54:11 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 5 Aug 2002 14:54:11 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g75Es9uR072165; Mon, 5 Aug 2002 10:54:10 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020805022847.14698.qmail@web11407.mail.yahoo.com> Date: Mon, 05 Aug 2002 10:54:05 -0400 (EDT) From: John Baldwin To: Shizuka Kudo , bmilekic@FreeBSD.rog Subject: Re: current panic on apache2 after sys/kern/subr_mbuf.c commit Cc: freebsd-current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 05-Aug-2002 Shizuka Kudo wrote: > > --- Shizuka Kudo wrote: >> Dear all, >> >> I have been experiencing panic with Apache2 since Jul 31. The system boot, but panic when >> someone >> access the apache2 service. After trace back, the subr_mbuf.c commit at around Jul 30 21:30 GMT >> is >> the candidate for this panic. Does anyone see the same problem as me? >> > > I think I find the problem which is the missing of assignment on one of the malloc call. Here's > the patch that seems to fix the problem. > > --- usr/src/sys/kern/subr_mbuf.c Thu Aug 1 22:24:41 2002 > +++ /usr/src/sys/kern/subr_mbuf.c Mon Aug 5 10:20:14 2002 > @@ -1051,7 +1051,7 @@ > > #define _mext_init_ref(m, ref) do { \ > if ((ref) == NULL) \ > - malloc(sizeof(u_int), M_MBUF, M_NOWAIT); \ > + (m)->m_ext.ref_cnt = malloc(sizeof(u_int), M_MBUF, M_NOWAIT); \ > else \ > (m)->m_ext.ref_cnt = (u_int *)(ref); \ > if ((m)->m_ext.ref_cnt != NULL) { \ Bosko, is this patch right and should it be committed? There is obviously a bug in calling malloc() and not storing the return value. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message