From owner-cvs-src@FreeBSD.ORG  Mon Oct 10 10:12:21 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D9FF16A41F;
	Mon, 10 Oct 2005 10:12:21 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E1ED343D48;
	Mon, 10 Oct 2005 10:12:20 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.48.2])
	by phk.freebsd.dk (Postfix) with ESMTP id 57A22BC74;
	Mon, 10 Oct 2005 10:12:19 +0000 (UTC)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Mon, 10 Oct 2005 12:10:13 +0200."
	<20051010101013.GB3975@garage.freebsd.pl> 
Date: Mon, 10 Oct 2005 12:12:19 +0200
Message-ID: <13707.1128939139@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: Peter Edwards <peadar@FreeBSD.org>, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	S?ren Schmidt <sos@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2005 10:12:21 -0000

In message <20051010101013.GB3975@garage.freebsd.pl>, Pawel Jakub Dawidek write
s:
>
>On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote:
>+> On 09/10/2005, at 23:11, Peter Edwards wrote:
>+> 
>+> Why did you ask me to review this when you just committed it anyway ?
>+> 
>+> As I said I'm not sure this is the right way to fix this..
>
>It seems to be right. I do it in my GEOM classes to handle g_clone_bio()
>failures better. So the only objection I may have is that it could be
>done a bit cleaner:

Please see geom_disk.c

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.