From owner-freebsd-ports-bugs@freebsd.org Sat Dec 5 16:22:12 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DB72A42592 for ; Sat, 5 Dec 2015 16:22:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6F52A1CC2 for ; Sat, 5 Dec 2015 16:22:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id tB5GMC51015546 for ; Sat, 5 Dec 2015 16:22:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205039] sysutils/pesign: unbreak on pre-10.2 systems Date: Sat, 05 Dec 2015 16:22:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: trasz@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2015 16:22:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205039 Bug ID: 205039 Summary: sysutils/pesign: unbreak on pre-10.2 systems Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: trasz@FreeBSD.org Reporter: jbeich@FreeBSD.org Assignee: trasz@FreeBSD.org Flags: maintainer-feedback?(trasz@FreeBSD.org), merge-quarterly? Created attachment 163870 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=163870&action=edit use poll(2) and copy strchrnul(3) from 10.x Looking at how ppoll(2) is implemented it seems the following is true ppoll(,, NULL, NULL) == poll(,, INFTIM) Our manpage is a bit vague but the one on Linux has If the sigmask argument is specified as NULL, then no signal mask manipulation is performed (and thus ppoll() differs from poll() only in the precision of the timeout argument). If timeout_ts is specified as NULL, then ppoll() can block indefinitely. But FreeBSD 9.x also needs another fix client.c: In function 'get_token_pin': client.c:244:3: error: implicit declaration of function 'strchrnul' [-Werror=implicit-function-declaration] char *c = strchrnul(pin, '\n'); ^ client.c:244:13: error: initialization makes pointer from integer without a cast [-Werror] char *c = strchrnul(pin, '\n'); ^ client.c:262:13: error: initialization makes pointer from integer without a cast [-Werror] char *c = strchrnul(pin, '\n'); ^ cc1: all warnings being treated as errors poudriere bulk -t build logs: - 9.3R i386: http://sprunge.us/MaEO - 9.3R amd64: http://sprunge.us/cTYG - 10.1R i386: http://sprunge.us/fjGN - 10.2R amd64: http://sprunge.us/ZfFK - 11.0C i386: http://sprunge.us/JcIb Would you like the patch land in /branches/2015Q4 as well? -- You are receiving this mail because: You are the assignee for the bug.