From owner-svn-src-all@FreeBSD.ORG  Mon Jun  6 06:32:47 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C7F1D1065670;
	Mon,  6 Jun 2011 06:32:47 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 79A438FC18;
	Mon,  6 Jun 2011 06:32:46 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA17641;
	Mon, 06 Jun 2011 09:32:43 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1QTTMg-000Als-QV; Mon, 06 Jun 2011 09:32:42 +0300
Message-ID: <4DEC748A.8000204@FreeBSD.org>
Date: Mon, 06 Jun 2011 09:32:42 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.17) Gecko/20110503 Lightning/1.0b2 Thunderbird/3.1.10
MIME-Version: 1.0
To: Pan Tsu <inyaoo@gmail.com>, Gerald Pfeifer <gerald@FreeBSD.org>
References: <201106052101.p55L1feL097420@svn.freebsd.org>
	<86zklwezwb.fsf@gmail.com>
In-Reply-To: <86zklwezwb.fsf@gmail.com>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r222723 - head/sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jun 2011 06:32:47 -0000

on 06/06/2011 00:23 Pan Tsu said the following:
> Andriy Gapon <avg@FreeBSD.org> writes:
> 
>> Author: avg
>> Date: Sun Jun  5 21:01:41 2011
>> New Revision: 222723
>> URL: http://svn.freebsd.org/changeset/base/222723
>>
>> Log:
>>   add SNDCTL_DSP_HALT specified by OSS
>>   
>>   This is really a new name for SNDCTL_DSP_RESET.
>>   
>>   PR:		kern/156874
>>   Submitted by:	gerald
>>   MFC after:	1 week
>>
>> Modified:
>>   head/sys/sys/soundcard.h
>>
>> Modified: head/sys/sys/soundcard.h
>> ==============================================================================
>> --- head/sys/sys/soundcard.h	Sun Jun  5 20:22:56 2011	(r222722)
>> +++ head/sys/sys/soundcard.h	Sun Jun  5 21:01:41 2011	(r222723)
>> @@ -311,7 +311,8 @@ typedef struct _snd_capabilities {
>>   * IOCTL Commands for /dev/sequencer
>>   */
>>  
>> -#define SNDCTL_SEQ_RESET	_IO  ('Q', 0)
>> +#define SNDCTL_SEQ_HALT		_IO  ('Q', 0)
>> +#define SNDCTL_SEQ_RESET	SNDCTL_SEQ_HALT	/* Historic interface */
> 
> Apparently, the one for /dev/sequencer is too new to be documented.
> 
>   http://manuals.opensound.com/developer/SNDCTL_SEQ_HALT.html -> "Not found"

Woops!  I admit I just copied the description and the patch from the PR.
How inattentive I could be while doing that?

Gerald, should the patch have actually introduced SNDCTL_DSP_HALT as the
description says?

>>  #define SNDCTL_SEQ_SYNC		_IO  ('Q', 1)
>>  #define SNDCTL_SYNTH_INFO	_IOWR('Q', 2, struct synth_info)
>>  #define SNDCTL_SEQ_CTRLRATE	_IOWR('Q', 3, int) /* Set/get timer res.(hz) */


-- 
Andriy Gapon