Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 06 Jun 2011 09:32:42 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Pan Tsu <inyaoo@gmail.com>, Gerald Pfeifer <gerald@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r222723 - head/sys/sys
Message-ID:  <4DEC748A.8000204@FreeBSD.org>
In-Reply-To: <86zklwezwb.fsf@gmail.com>
References:  <201106052101.p55L1feL097420@svn.freebsd.org> <86zklwezwb.fsf@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
on 06/06/2011 00:23 Pan Tsu said the following:
> Andriy Gapon <avg@FreeBSD.org> writes:
> 
>> Author: avg
>> Date: Sun Jun  5 21:01:41 2011
>> New Revision: 222723
>> URL: http://svn.freebsd.org/changeset/base/222723
>>
>> Log:
>>   add SNDCTL_DSP_HALT specified by OSS
>>   
>>   This is really a new name for SNDCTL_DSP_RESET.
>>   
>>   PR:		kern/156874
>>   Submitted by:	gerald
>>   MFC after:	1 week
>>
>> Modified:
>>   head/sys/sys/soundcard.h
>>
>> Modified: head/sys/sys/soundcard.h
>> ==============================================================================
>> --- head/sys/sys/soundcard.h	Sun Jun  5 20:22:56 2011	(r222722)
>> +++ head/sys/sys/soundcard.h	Sun Jun  5 21:01:41 2011	(r222723)
>> @@ -311,7 +311,8 @@ typedef struct _snd_capabilities {
>>   * IOCTL Commands for /dev/sequencer
>>   */
>>  
>> -#define SNDCTL_SEQ_RESET	_IO  ('Q', 0)
>> +#define SNDCTL_SEQ_HALT		_IO  ('Q', 0)
>> +#define SNDCTL_SEQ_RESET	SNDCTL_SEQ_HALT	/* Historic interface */
> 
> Apparently, the one for /dev/sequencer is too new to be documented.
> 
>   http://manuals.opensound.com/developer/SNDCTL_SEQ_HALT.html -> "Not found"

Woops!  I admit I just copied the description and the patch from the PR.
How inattentive I could be while doing that?

Gerald, should the patch have actually introduced SNDCTL_DSP_HALT as the
description says?

>>  #define SNDCTL_SEQ_SYNC		_IO  ('Q', 1)
>>  #define SNDCTL_SYNTH_INFO	_IOWR('Q', 2, struct synth_info)
>>  #define SNDCTL_SEQ_CTRLRATE	_IOWR('Q', 3, int) /* Set/get timer res.(hz) */


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DEC748A.8000204>