From owner-cvs-usrsbin Sun Oct 5 08:23:35 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA25216 for cvs-usrsbin-outgoing; Sun, 5 Oct 1997 08:23:35 -0700 (PDT) Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA25203; Sun, 5 Oct 1997 08:23:15 -0700 (PDT) Received: from gate.lan.awfulhak.org (localhost [127.0.0.1]) by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id QAA14713; Sun, 5 Oct 1997 16:23:04 +0100 (BST) Message-Id: <199710051523.QAA14713@awfulhak.demon.co.uk> X-Mailer: exmh version 2.0zeta 7/24/97 To: Brian Somers cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/ppp lcp.c In-reply-to: Your message of "Sun, 05 Oct 1997 08:00:11 PDT." <199710051500.IAA01014@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 05 Oct 1997 16:23:04 +0100 From: Brian Somers Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > brian 1997/10/05 08:00:11 PDT > > Modified files: > usr.sbin/ppp lcp.c > Log: > Change things around a bit when bringing down the layers. > > o LcpLayerDown() no longer does a NewPhase(PHASE_TERMINATE). > Instead, it's done in LcpLayerFinish(). LayerFinish() gets > called by the FSM after the LCP FSM goes through the Stopping > and Stopped states. > > o -direct and -background mode exit at PHASE_TERMINATE, not > PHASE_DEAD. > > The result is that LCP, CCP & IPCP are brought down cleanly on both > sides of the link (not just our side). Killing ppp rather than just > closing it still makes it get out after the LCP SendTerminateReq(). > I'll have a look at that soon. We're probably not actually sending > the REQ :-( > > Revision Changes Path > 1.38 +12 -3 src/usr.sbin/ppp/lcp.c This has only been proven on 3 different ppp implementations (one of which is ppp itself). Anyone caring to [dis]prove things elsewhere would have my thanks :-) One other thing.... this should remove the necessity for the "set stopped" command ! -- Brian , , Don't _EVER_ lose your sense of humour....