From owner-freebsd-current@FreeBSD.ORG  Mon Jun  8 15:33:57 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 69E66106574C
	for <freebsd-current@freebsd.org>; Mon,  8 Jun 2009 15:33:57 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 37AD68FC0C
	for <freebsd-current@freebsd.org>; Mon,  8 Jun 2009 15:33:57 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id E229746B53;
	Mon,  8 Jun 2009 11:33:56 -0400 (EDT)
Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id D5D948A068;
	Mon,  8 Jun 2009 11:33:55 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Mon, 8 Jun 2009 11:00:05 -0400
User-Agent: KMail/1.9.7
References: <20090606021835.GC1077@darklight.homeunix.org>
	<20090606175158.GA1080@darklight.homeunix.org>
In-Reply-To: <20090606175158.GA1080@darklight.homeunix.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906081100.06174.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Mon, 08 Jun 2009 11:33:55 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.4 required=4.2 tests=AWL,BAYES_00,RDNS_NONE,
	SUBJECT_FUZZY_TION autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Yuri Pankov <yuri.pankov@gmail.com>
Subject: Re: loader panics with 2 GPT partitioned drives
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2009 15:33:58 -0000

On Saturday 06 June 2009 1:51:58 pm Yuri Pankov wrote:
> On Sat, Jun 06, 2009 at 06:18:35AM +0400, Yuri Pankov wrote:
> > Hi,
> > 
> > I'm getting the following "panic" from loader when trying to attach
> > another GPT partitioned drive. loader is built using LOADER_ZFS_SUPPORT.
> > 
> > BTX Loader 1.00  BTX version is 1.02
> > Consoles: internal video/keyboard
> > BIOS drive C: is disk0
> > BIOS drive D: is disk1
> > 
> > panic:free: guard1 fail @ 0x7fd4b3f4 from
> > /usr/src/sys/boot/i386/libi386/biosdisk.c:1048
> > 
> > 
> > ad4:
> > =>       34  488397101  ad4  GPT  (233G)
> >          34        128    1  freebsd-boot  (64K)
> >         162   16777216    2  freebsd-swap  (8.0G)
> >    16777378  471619757    3  freebsd-zfs  (225G)
> > 
> > ad10:
> > empty disk, `gpart create -s GPT ad10`
> > 
> > 
> > 
> > Yuri
> 
> Looks like there are no checks in loader with GPT support if there are
> no partitions defined (very rare case, but still.. :-). Attached patch
> fixes booting with GPT disk without partitions (for me).

That is the correct fix.

-- 
John Baldwin