From owner-freebsd-stable@FreeBSD.ORG Tue Aug 16 14:15:04 2005 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4437B16A41F; Tue, 16 Aug 2005 14:15:04 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 664C343D45; Tue, 16 Aug 2005 14:15:03 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id j7GEF0re086761; Tue, 16 Aug 2005 18:15:01 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.3/8.13.3/Submit) id j7GEF0e6086760; Tue, 16 Aug 2005 18:15:00 +0400 (MSD) (envelope-from yar) Date: Tue, 16 Aug 2005 18:15:00 +0400 From: Yar Tikhiy To: Boris Samorodov Message-ID: <20050816141500.GB86251@comp.chem.msu.su> References: <20050714101507.GA82562@comp.chem.msu.su> <20050718151924.GF26849@comp.chem.msu.su> <21429884@srv.sem.ipt.ru> <20050811153408.GF84643@comp.chem.msu.su> <17746550@serv3.int.kfs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17746550@serv3.int.kfs.ru> User-Agent: Mutt/1.5.9i Cc: freebsd-stable@freebsd.org, peter@freebsd.org Subject: Re: Build failure in procfs module X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 14:15:04 -0000 On Tue, Aug 16, 2005 at 01:29:45AM +0400, Boris Samorodov wrote: > On Thu, 11 Aug 2005 19:34:09 +0400 Yar Tikhiy wrote: > > On Thu, Aug 04, 2005 at 12:28:35PM +0400, Boris Samorodov wrote: > > > On Mon, 18 Jul 2005 19:19:24 +0400 Yar Tikhiy wrote: > > > > On Thu, Jul 14, 2005 at 02:15:07PM +0400, Yar Tikhiy wrote: > > > > > > > > > > I ran into a problem that might be triggered by Peter's recent > > > > > changes to procfs. Namely, the buildworld procedure would fail in > > > > > the procfs module if MODULES_WITH_WORLD were set. I noticed it > > > > > first in CURRENT and then tested it in a clean environment by > > > > > building a freshly CVSup'd RELENG_6 on a freshly installed 5.4-RELEASE, > > > > > with MODULES_WITH_WORLD set. I think it's a route of upgrading > > > > > quite a few people will follow. > > > > > > > > > > Here's the diagnostics: > > [snip] > > > > The problem appears to have to do with Peter's changes to procfs: > > > > The procfs source files now include opt_compat.h, which is not > > > > available by default when building with MODULES_WITH_WORLD set. > > > > The attached patch seems to fix the problem in the conventional > > > > way. However, I'm unsure which COMPAT_* options are really needed > > > > to the procfs module. COMPAT_43 should be enough according to my > > > > quick examining /sys/fs/procfs. > > > > > > Was the case corrected in BETA2? A couple of days ago I upgraded from > > > CURRENT (middle of June 2005) to BETA1. The problem existed but the > > > patch helped. > > > Alas, no one has displayed interest in fixing this bug since I left > > for vacation. I committed the fix to CURRENT today although I don't > > use procfs, which is a kind of a situation I hate. MFC to RELENG_6 > > is due in 3 days. > > Could you (or somebody else) MFC the patch to RELENG_6? RELENG_6 is frozen now, so I must receive RE's approval before merging my change to the branch. Discussion with re@ and some expert developers is under way. Applying for the approval has appeared the best way to draw attention to the issue :-) -- Yar