From owner-svn-ports-all@FreeBSD.ORG Sun Dec 28 11:00:49 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED19C459; Sun, 28 Dec 2014 11:00:49 +0000 (UTC) Received: from mail-pd0-x231.google.com (mail-pd0-x231.google.com [IPv6:2607:f8b0:400e:c02::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B65BB1ADF; Sun, 28 Dec 2014 11:00:49 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id ft15so15374872pdb.22; Sun, 28 Dec 2014 03:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=vc5gURSmqsQgG80dctuBZp9WQwPj+qR32aZQpr8HIpA=; b=tIgTYaPYhZ1cyRHK5Y9cTpJXIl3BOfpw1xB6CxQYiO/K33+eXafTFh2wk8TGBXBGV6 gozLIITalJJCDsqXYYjMxMq1CGNn7/NrCmRPEmA0BiKimgWaswpjCyO/8f6gcHTbtJGI jj0TR3jqT321WsViMcUJulFsaUkurQ2NMjNEtRSbyVfpRqjoqTismLveUbh09BVr7Ctg KCxF09xH+sPt3xt8DZsHlAc3TABEzeQLp3/GKnm3zewgmDWiJfRHiEbiA3TLi16+zRff vt/7SFmXHnoiSebjUn7LqBAh1fWfRcb/9eAkAOpmPtcuIDVuvBbtdUnQcCQXokO0g6VU sF/Q== X-Received: by 10.66.119.175 with SMTP id kv15mr82888371pab.30.1419764449300; Sun, 28 Dec 2014 03:00:49 -0800 (PST) Received: from [192.168.1.109] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id a5sm10700328pat.24.2014.12.28.03.00.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Dec 2014 03:00:48 -0800 (PST) Sender: Kubilay Kocak Message-ID: <549FE2CE.9050006@FreeBSD.org> Date: Sun, 28 Dec 2014 22:00:30 +1100 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Thunderbird/34.0 MIME-Version: 1.0 To: Gerald Pfeifer Subject: Re: svn commit: r375696 - head/multimedia/libx264 References: <201412280459.sBS4xbU9021196@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2014 11:00:50 -0000 On 28/12/2014 9:01 PM, Gerald Pfeifer wrote: > On Sunday 2014-12-28 04:59, Kubilay Kocak wrote: >> Log: >> multimedia/libx264: Fix PGO/GCC options >> >> - Revert options helpers for PGO and GCC .. *shakes fist*. We end up >> setting USE_GCC=yes yes otherwise, and that's not valid. >> - libx264 and x264 share the same distfiles, use the same DIST_SUBDIR > >> +.if ${PORT_OPTIONS:MGCC} >> +USE_GCC= yes >> +.elif ${PORT_OPTIONS:MPGO} >> +USE_GCC= any >> +.endif > > Why not USE_GCC=yes in either case? > > Using anything like the old version of GCC in base (GCC 4.2) for > anyone asking for PGO feels just, hmm, odd. Plus it complicates > the testing matrix. > > Gerald > 'any' wont clobber user values with the latest or default version as detailed in Mk/bsd.gcc.mk, according to my reading and `make test-gcc` for each of the permutations. In this case I prefer to preserve user choice, and I can't guess what and how users want to do with the software. Speaking from personal experience, I would not want > 1 gcc versions built and/or installed if I was forced for whatever reason to use it (eg: PGO until libprofile_rt in Clang lands in FreeBSD), whether or not 4.2.1 provided statistically significant benefits over later versions. tl;dr I'm thinking of the users. I hope that's good enough :) Koobs