From owner-freebsd-ipfw Wed Jul 28 13: 9:44 1999 Delivered-To: freebsd-ipfw@freebsd.org Received: from ns.mt.sri.com (ns.mt.sri.com [206.127.79.91]) by hub.freebsd.org (Postfix) with ESMTP id 2A12D154B1; Wed, 28 Jul 1999 13:09:38 -0700 (PDT) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id OAA04881; Wed, 28 Jul 1999 14:08:50 -0600 (MDT) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id OAA02877; Wed, 28 Jul 1999 14:08:49 -0600 Date: Wed, 28 Jul 1999 14:08:49 -0600 Message-Id: <199907282008.OAA02877@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: "Brian F. Feldman" Cc: Nate Williams , hackers@FreeBSD.org, freebsd-ipfw@FreeBSD.org Subject: Re: securelevel and ipfw zero In-Reply-To: References: <199907282000.OAA02728@mt.sri.com> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-ipfw@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > > @@ -302,14 +303,15 @@ > > > struct ifnet *rif, struct ifnet *oif) > > > { > > > if (ip) { > > > + struct tcphdr *const tcp = (struct tcphdr *)((u_int32_t *)ip+ip->ip_hl); > > > + struct udphdr *const udp = (struct udphdr *)((u_int32_t *)ip+ip->ip_hl); > > > + struct icmp *const icmp = (struct icmp *)((u_int32_t *)ip+ip->ip_hl); > > > static u_int64_t counter; > > > - struct tcphdr *const tcp = (struct tcphdr *) ((u_int32_t *) ip+ ip->ip_hl); > > > - struct udphdr *const udp = (struct udphdr *) ((u_int32_t *) ip+ ip->ip_hl); > > > - struct icmp *const icmp = (struct icmp *) ((u_int32_t *) ip + ip->ip_hl); > > > - int count; > > > + u_int64_t count; > > > > These are mostly change for changes sake, and make it difficult to see > > the functional changes. Please limit your changes to changes, and not > > just to add stylistic differences. While I may agree with them, they > > detract from the review process. > > These were changes that were necessary to make ipfw readable enough that > I could work with it in this area. They aren't just to clean it up, or > just for change's sake. They need to stay in. C'mon now, re-ording the lines is *certainly* not necessary to work. *rant on* Brian, FreeBSD isn't your private playground for playing around, this is a group project, and you gotta follow the rules, or you don't get to play with the rest of the folks.... *rant off* Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ipfw" in the body of the message