From owner-freebsd-current  Thu Jan 25 16:34:55 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.3/8.7.3) id QAA21379
          for current-outgoing; Thu, 25 Jan 1996 16:34:55 -0800 (PST)
Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33])
          by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id QAA21373
          for <current@FreeBSD.org>; Thu, 25 Jan 1996 16:34:51 -0800 (PST)
Received: from localhost.shockwave.com (localhost.shockwave.com [127.0.0.1]) by precipice.shockwave.com (8.7.3/8.7.3) with SMTP id QAA00452; Thu, 25 Jan 1996 16:33:36 -0800 (PST)
Message-Id: <199601260033.QAA00452@precipice.shockwave.com>
To: "Marc G. Fournier" <scrappy@ki.net>
cc: current@FreeBSD.org
Subject: Re: ether_sprintf bug: possible patch? 
In-reply-to: Your message of "Thu, 25 Jan 1996 16:29:43 EST."
             <Pine.BSF.3.91.960125162519.9225c-100000@ki.net> 
Date: Thu, 25 Jan 1996 16:33:35 -0800
From: Paul Traina <pst@shockwave.com>
Sender: owner-current@FreeBSD.org
Precedence: bulk

no, just re sup and you should be ok, that patch takes us backwards, %D isn't
used anumore as far as I recall...

  From: "Marc G. Fournier" <scrappy@ki.net>
  Subject: ether_sprintf bug: possible patch?
  
  Hi...
  
  	Just searched through if_ed.c, which is dated as being last
  modified yesterday (Jan24) to see if I can find what is going on, and
  found this:
  
  <excerpt from if_ed.c>
          /*
           * Print additional info when attached
           */
          printf("ed%d: address %6D, ", isa_dev->id_unit,
                  sc->arpcom.ac_enaddr, ":");
  
          if (sc->type_str && (*sc->type_str != 0))
                  printf("type %s ", sc->type_str);
          else
                  printf("type unknown (0x%x) ", sc->type);
  
          printf("%s ", sc->isa16bit ? "(16 bit)" : "(8 bit)");
  
          printf("%s\n", ((sc->vendor == ED_VENDOR_3COM) &&
                 (ifp->if_flags & IFF_ALTPHYS)) ? " tranceiver disabled" : "");
  ki# grep ether_sprintf if_ep.c
      printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr));
  
  
  	Can someone clarify for me as to whether I would be correct in 
  assuming that the following "patch" would work or break something?  I'm
  going to to try it, but, if I'm missing something due to ignorance... :(
  
  *** if_ep.c.orig        Thu Jan 25 16:28:22 1996
  --- if_ep.c     Thu Jan 25 16:28:53 1996
  ***************
  *** 408,414 ****
          GO_WINDOW(2);
          outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
        }
  !     printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr));
  
        /*
         * Write IRQ value to board
  --- 408,414 ----
          GO_WINDOW(2);
          outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i]));
        }
  !     printf(" address %6D", sc->arpcom.ac_enaddr);
  
        /*
         * Write IRQ value to board
  
  
  Marc G. Fournier | POP Mail  Telnet Acct  DNS Hosting
  System           |  WWW Services   Database Services  | Knowledge, 
    Administrator  |                                    | Information and
   scrappy@ki.net  |      WWW: http://www.ki.net        | Communications, Inc