From owner-cvs-all@FreeBSD.ORG Fri Aug 4 16:18:18 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5948C16A4E5; Fri, 4 Aug 2006 16:18:18 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3CDC43D7C; Fri, 4 Aug 2006 16:18:11 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k74GEwC1098549; Fri, 4 Aug 2006 10:14:58 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 04 Aug 2006 10:14:58 -0600 (MDT) Message-Id: <20060804.101458.104131397.imp@bsdimp.com> To: glebius@freebsd.org From: Warner Losh In-Reply-To: <20060804095414.GU96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Fri, 04 Aug 2006 10:14:59 -0600 (MDT) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, pdeuskar@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 16:18:18 -0000 From: Gleb Smirnoff Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h Date: Fri, 4 Aug 2006 13:54:14 +0400 > Prafulla, > > On Thu, Aug 03, 2006 at 07:05:05PM +0000, Prafulla Deuskar wrote: > P> pdeuskar 2006-08-03 19:05:05 UTC > P> > P> FreeBSD src repository > P> > P> Modified files: > P> sys/dev/em if_em.c if_em.h > P> Log: > P> Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > P> This makes it easier for us to get the changes into -current and to -stable quickly. > > Can you please confirm that this was a mechanical substitution like this: > > s/sc/adapter/g > s/em_softc/adapter/g > > and no more additional changes? If this is true, then I hope that we > (FreeBSD and Intel) have finally came to a common codebase. This is good. :) > I can stand the long unusual name for driver softc with no problems. That's what my eyeball of the patch showed. > I'm only a bit disappointed by the fact, that I haven't received a single > email about these plans. You were in the void for a long time, and > then began your work with a commit, w/o informing people who were > maintaining driver while the vendor maintanance was on a hiatus. You can blame that last part. Prafulla had sent several versions of the patch to me for review. I had gotten the mistaken impression that you were not longer interested in em (which appears to be in error), so I didn't have him bounce them off of you first. Please accept my appologies for not suggesting you be in the loop more. I gave him my signoff on the patch a few hours after you commited to em, but I didn't notice this until after he'd committed (gotta love qwest, nuf said). I soon realized my mistake, and would like to offer a public appology for it. Warner