Date: Fri, 19 Mar 2004 06:00:37 -0800 (PST) From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/64425: [NEW PORT]: net/netatalk-devel Message-ID: <200403191400.i2JE0b5V042354@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/64425; it has been noted by GNATS. From: Oliver Eikemeier <eikemeier@fillmore-labs.com> To: tom hensel <tom@replic8.net>, freebsd-gnats-submit@FreeBSD.org Cc: Subject: Re: ports/64425: [NEW PORT]: net/netatalk-devel Date: Fri, 19 Mar 2004 14:53:54 +0100 tom hensel wrote: > hi, > >>I still get FATAL errors with portlint -A. > > i'm doing kinda incremental updates :) Please, do not send-pr unfinished ports. GNATS is not a good development platform. Subscribe to ports@ and ask questions there until you get things straightened out: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>; >>README.html is a generated file and not part of a port. > > going to remove it. good. >>Why don't you simply download 2.0 alpha2? Please use fixed snapshots >>when possible. If you want to add extra patches, you can add them >>as PATCHFILES, possibly conditionalized on WITH_CUPS_PATCH or >>WITHOUT_CUPS_PATCH. > > simple answer, it just doesn't build (without ugly hacks). > the snapshots from CVS have a lot of fixes, especially for > BSDs. see the discussion on the sourceforge forums. Seduce them to publish dated CVS snapshots. It is hard to guarantee that the next CVS version won't break things again or break your patches. Besides, it makes support a nightmare. >>You should change the PKGNAMESUFFIX accordingly. > > sorry, how? <http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#AEN553>; >>You might want to convert files/netatalk.sh to a rcNG script, which >>should be easy if you are used to pkgsrc. > > yes, good idea :) Nice. Maybe you could submit this as an update to net/netatalk too. >>The WANT_AUTO* variables are somewhat deprecated, please use the >>USE_AUTO equivaltents. Do you really need all those tools? Normally >>packages contain a pregenerated configure script, so that only >>GNU_CONFIGURE is necessary. Otherwise patching the configure >>script doesn't make sense. You should not need to patch ltmain.sh >>if you USE_LIBTOOL from the ports. > > i could not get it to build without using WANT_AUTO_*. > to be honest, i don't know why. Find out, you want to maintain this port, you are supposed to know. >>Where is it that you use perl? > > most of the things you point out come from the original netatalk-port, > i'm just keeping some things (like perl) for now. > maybe the netatalk-port needs some update, too. This is not really true, which of the issues above apply to net/netatalk? So, why do you need perl? >>I know that "See Netatalk's Makefile for more details on some of these >>options." is from marcus@ port, but I don't consider this very helpful. > > i agree. ok. >> share/nls/POSIX >> share/nls/en_US.US-ASCII >>are not generated by your port, and shouldn't be part of the packing list. > > hm, i used a script to automagically generate pkg-plist. just don't know > where these come from, going to remove them. generating packing lists automatically is not easy and needs manual editing. You are supposed to test `make package', pkg_add and pkg_delete to be sure the packing list is right. >>There are still manpages in the packing list. > > thought i removed them all, sigh. Nope. Test packaging. >>You should not remove user-editable configuration files, at least not >>if they are edited by the user. > > i did not intend this. again it's just like the netatalk-port. Not true. Look into net/netatalk/pkg-plist > <http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/index.html>; > > aight, forgot about it. It is referenced on <http://www.freebsd.org/ports/>. > many thanks for your detailled comments! some work to do... I'll mark this PR as suspended until the port is ready.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403191400.i2JE0b5V042354>