From owner-svn-ports-all@FreeBSD.ORG Thu Apr 9 06:06:57 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 844072AE; Thu, 9 Apr 2015 06:06:57 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57A40A86; Thu, 9 Apr 2015 06:06:56 +0000 (UTC) Received: from [192.168.1.22] (159.Red-79-148-64.dynamicIP.rima-tde.net [79.148.64.159]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 03E1A43C27; Thu, 9 Apr 2015 01:06:46 -0500 (CDT) Message-ID: <552616F3.9080500@marino.st> Date: Thu, 09 Apr 2015 08:06:43 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bryan Drewery , Dmitry Marakasov Subject: Re: svn commit: r383191 - head/Mk References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> In-Reply-To: <5525D48E.5090305@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 06:06:57 -0000 On 4/9/2015 03:23, Bryan Drewery wrote: > On 4/8/2015 6:21 PM, Dmitry Marakasov wrote: >> * Bryan Drewery (bdrewery@FreeBSD.org) wrote: >> >>>>> Re-enable and rework check added in r370464 to validate the first CATEGORY >>>>> is set properly. The problem causing the revert in r370475 was fixed in >>>>> r383190. >>>>> >>>>> With hat: portmgr >>>> >>>> This breaks countless usecases when port is build which does not belong >>>> to the ports tree. >>> >>> Please name even 1 case. >> >> I have a lot of WIP ports in flat directory. Tons of custom port >> repositories on github with flat structure. > > Short of more details, that does not sound like a supported setup. > > I can't read your mind. Please give me a specific case or I can't help. Since it's obviously a custom tree, he could always just patch this check out. I'd be surprised if no other Mk file was patched already. >>>> Afaik, we have that information in ports - based on >>>> that PORTSDIR is chosen. The same mechanism should be used here to >>>> conditionally enable the check. >>> >>> That made no sense. >> >> Explain. >> > > I do not understand what you are trying to say. It makes no sense. He's saying the check should be conditional based on PORTSDIR, but this sounds wrong to me. What about /usr/dports? What about somebody that intentionally installs ports somewhere other than /usr/ports ? He should be using reviews.freebsd.org for code suggestions so we can see the implementation. John