From owner-svn-src-all@FreeBSD.ORG Thu Feb 28 22:30:04 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 44E57260; Thu, 28 Feb 2013 22:30:04 +0000 (UTC) (envelope-from gonzo@id.bluezbox.com) Received: from id.bluezbox.com (id.bluezbox.com [88.198.91.248]) by mx1.freebsd.org (Postfix) with ESMTP id EB69E73F; Thu, 28 Feb 2013 22:30:03 +0000 (UTC) Received: from [88.198.91.248] (helo=[IPv6:::1]) by id.bluezbox.com with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.77 (FreeBSD)) (envelope-from ) id 1UBBzE-000DdV-Ps; Thu, 28 Feb 2013 14:30:03 -0800 Message-ID: <512FDA67.80200@freebsd.org> Date: Thu, 28 Feb 2013 14:29:59 -0800 From: Oleksandr Tymoshenko User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Ian Lepore Subject: Re: svn commit: r247495 - head/sys/dev/sdhci References: <201302281943.r1SJhEmC023261@svn.freebsd.org> <1362081750.1195.65.camel@revolution.hippie.lan> In-Reply-To: <1362081750.1195.65.camel@revolution.hippie.lan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: gonzo@id.bluezbox.com X-Spam-Level: -- X-Spam-Report: Spam detection software, running on the system "id.bluezbox.com", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see The administrator of that system for details. Content preview: On 2/28/2013 12:02 PM, Ian Lepore wrote: > On Thu, 2013-02-28 at 19:43 +0000, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Thu Feb 28 19:43:14 2013 >> New Revision: 247495 >> URL: http://svnweb.freebsd.org/changeset/base/247495 >> >> Log: >> Add hooks for plugging platform-provided transfer backend. >> >> In order to use platorm backend hardware driver should >> impement three methods: >> - platform_start_transfer and platform_finish_transfer >> to start and finish transfer >> - platform_will_handle - check whether transaction is >> suitable for backend. If not - driver will fall back >> to PIO mode. >> >> Submitted by: Daisuke Aoyama >> Approved by: ian@ >> >> Modified: >> head/sys/dev/sdhci/sdhci.c >> head/sys/dev/sdhci/sdhci.h >> head/sys/dev/sdhci/sdhci_if.m >> > I think that was meant to be "Reviewed by" rather than "Approved by". I > do very much approve of the changes, but not in any formal > administrative sense, I'm just happy the sdcard IO is faster. :) > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2013 22:30:04 -0000 On 2/28/2013 12:02 PM, Ian Lepore wrote: > On Thu, 2013-02-28 at 19:43 +0000, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Thu Feb 28 19:43:14 2013 >> New Revision: 247495 >> URL: http://svnweb.freebsd.org/changeset/base/247495 >> >> Log: >> Add hooks for plugging platform-provided transfer backend. >> >> In order to use platorm backend hardware driver should >> impement three methods: >> - platform_start_transfer and platform_finish_transfer >> to start and finish transfer >> - platform_will_handle - check whether transaction is >> suitable for backend. If not - driver will fall back >> to PIO mode. >> >> Submitted by: Daisuke Aoyama >> Approved by: ian@ >> >> Modified: >> head/sys/dev/sdhci/sdhci.c >> head/sys/dev/sdhci/sdhci.h >> head/sys/dev/sdhci/sdhci_if.m >> > I think that was meant to be "Reviewed by" rather than "Approved by". I > do very much approve of the changes, but not in any formal > administrative sense, I'm just happy the sdcard IO is faster. :) > Yeah, wrong "to:" field :) Thanks for reviewing these patches