From owner-svn-src-all@freebsd.org Sat Jan 6 16:52:00 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 314C8EC19E9 for ; Sat, 6 Jan 2018 16:52:00 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x233.google.com (mail-yb0-x233.google.com [IPv6:2607:f8b0:4002:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E248B764EF for ; Sat, 6 Jan 2018 16:51:59 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x233.google.com with SMTP id 5so3005656ybp.4 for ; Sat, 06 Jan 2018 08:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pn+C+y+/bMs65dCrmzUelaQuf+DFMxLHEvVzq4CEpdw=; b=XTNWvFuoWhwXX3hvGDvXhVxACqjpv+YyPl3w1z418N3wTyREjWmPAag+sWr6OOgl8N FtmDwJKiLn9zWPTR37M2Ywft55y3aRFkWuRk4B1jJeXhGR66AvAE+4vpyKZCDkostrno cPfcF/RQ7qFxZp/W4ne5s2b5abOV/OKys/49I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pn+C+y+/bMs65dCrmzUelaQuf+DFMxLHEvVzq4CEpdw=; b=UTP4Uy5LZkrNyIenQHUEFVd5/hE2eZbmasRTYReLBjTLV+Nl8+ep4jITbRdjo+PuXA GXz4jWFTnnL8xEFTsa9V7Hn7m6P2ZyPrBHoDC4lGQKb4PXVy1IVEb85kqf4ABLyAwBkA PSXr3WRomoDW11EZGse0ptH+tVmfKi0c3ybXMBh+TPCv7cYRL3WLW88rj212+m0gF4gB 3/sOX0qMsAX8hXCXqI1qju4OFN4hfL27zbcJf3dZuoL/8wXUIreqe4Z3l1dl5i0ViW9h hGozs5MDK9+7LIE03Ui+yZtg2DS4q/buKkXt0Ic9NBt2OvkuC/bnTquW1vxmqNQXC4eH 7K/w== X-Gm-Message-State: AKGB3mLWY6sWBOi1vxu4ZxO/AxFRL2/t/v8AoeZqyhwLJRks44hN5+ez 0DvCYB5jsvM4qkXJ0ZQ4v3rRf+R+Q4YxM9vdb2ZOeQ== X-Google-Smtp-Source: ACJfBou7zrFFRwk31eLLGl5UolbQaKI6fyr8SFDGP7uUJwwvDD7OdFJQzG7lgm6ZmxMNGU999e8nJhB0VvKPjisLbgw= X-Received: by 10.37.31.69 with SMTP id f66mr6269088ybf.486.1515257518895; Sat, 06 Jan 2018 08:51:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.217.21 with HTTP; Sat, 6 Jan 2018 08:51:28 -0800 (PST) In-Reply-To: <8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4@FreeBSD.org> References: <201801060948.w069m4Rb058364@repo.freebsd.org> <8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4@FreeBSD.org> From: Eitan Adler Date: Sat, 6 Jan 2018 08:51:28 -0800 Message-ID: Subject: Re: svn commit: r327616 - head/usr.bin/morse To: Dimitry Andric Cc: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 16:52:00 -0000 On 6 January 2018 at 08:36, Dimitry Andric wrote: > On 6 Jan 2018, at 14:19, Eitan Adler wrote: >> >> On 6 January 2018 at 01:48, Li-Wen Hsu wrote: >>> Author: lwhsu (ports committer) >>> Date: Sat Jan 6 09:48:04 2018 >>> New Revision: 327616 >>> URL: https://svnweb.freebsd.org/changeset/base/327616 >>> >>> Log: >>> Unbreak build after r327614 >> >> Why is testing with "make obj; make" in the morse directory insufficient= ? >> >> =E2=88=B4make obj; make >> rm -f .depend >> echo morse.full: /usr/lib/libc.a >> .depend >> cc -O2 -pipe -g -MD -MF.depend.morse.o -MTmorse.o -std=3Dgnu99 >> -fstack-protector-strong -Wsystem-headers -Werror -Wall >> -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes >> -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual >> -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align >> -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls >> -Wold-style-definition -Wno-pointer-sign >> -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body >> -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments >> -c morse.c -o morse.o >> cc -O2 -pipe -g -std=3Dgnu99 -fstack-protector-strong -Wsystem-headers >> -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter >> -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type >> -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter >> -Wcast-align -Wchar-subscripts -Winline -Wnested-externs >> -Wredundant-decls -Wold-style-definition -Wno-pointer-sign >> -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body >> -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -o >> morse.full morse.o >> objcopy --only-keep-debug morse.full morse.debug >> objcopy --strip-debug --add-gnu-debuglink=3Dmorse.debug morse.full mors= e >> gzip -cn morse.6 > morse.6.gz > > Before r327616, I get: > > usr.bin/morse/morse.c:602:15: error: unused parameter 'stream' [-Werror,-= Wunused-parameter] > fdecode(FILE *stream) > ^ > 1 error generated. > > Maybe you have warnings turned off in your local build environment? Is there anything that I could set in my environment that would override the command line flags? --=20 Eitan Adler