From owner-svn-ports-all@freebsd.org Sun Oct 6 12:00:14 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69CFF143A6D; Sun, 6 Oct 2019 12:00:14 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46mMcZ1w93z49Jh; Sun, 6 Oct 2019 12:00:14 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-pg1-f196.google.com with SMTP id p1so4720260pgi.4; Sun, 06 Oct 2019 05:00:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jHuFLQLCZIrQ/YpVf3MC8iyXQI05SxLWEBQeJjLE5/8=; b=CQSI4OlKXppb2XecCyu7e+aUxTK+5/Jgm5d0rMH0mmY4WGrtlNFoXKU16pWJnKPcZa EmFdS4108MmRkBB6ZeBIJltVTFnp/lV1kUnp2SS7BUItnK2q7DcN/XxVFaPcUereDqfC znqrEPe/xfagN5fi4VX5Xo5ZYmMROJewV4oTmn15RbDG56IY2Oxggoo9MZgRGVqCRjH3 B7AEYdxkWVfokdM4+nPhOe5G2+dXsVcS3F81Lr7e7XbyEWeRufa6vnhKi8YiGF52OkI1 5kU01hIaQkOctHftpRD8iECt7MzCr7xirl8p5ulotYOxo7z2xvWDw0JSxA+gYQDLxUaC 8oLg== X-Gm-Message-State: APjAAAUX/XYfpZyR86dLQWEBXHvFOZNY9dVFiF/7prrRtpKRT7EqV9P/ uD2pZZRsBTnyY3PVMUimq2vKfslhpcqZDw== X-Google-Smtp-Source: APXvYqx8f28pmdvMpr6VNFir1EiCN4kFLh0ImzUoX5K78Tyije28uuUdtHLzSPAnxMvTR6ViDUgWKA== X-Received: by 2002:a17:90a:77c7:: with SMTP id e7mr28080100pjs.114.1570363211362; Sun, 06 Oct 2019 05:00:11 -0700 (PDT) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com. [209.85.210.169]) by smtp.gmail.com with ESMTPSA id p88sm12314349pjp.22.2019.10.06.05.00.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Oct 2019 05:00:11 -0700 (PDT) Received: by mail-pf1-f169.google.com with SMTP id q5so6825806pfg.13; Sun, 06 Oct 2019 05:00:10 -0700 (PDT) X-Received: by 2002:a63:dd05:: with SMTP id t5mr24680858pgg.16.1570363210302; Sun, 06 Oct 2019 05:00:10 -0700 (PDT) MIME-Version: 1.0 References: <201910031745.x93Hje5x059120@repo.freebsd.org> <20191006054444.GB62549@urd.tobik.me> <20191006081114.GA33887@urd.tobik.me> In-Reply-To: <20191006081114.GA33887@urd.tobik.me> From: Gleb Popov Date: Sun, 6 Oct 2019 15:59:43 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r513679 - head/sysutils/fusefs-smbnetfs/files To: Tobias Kortkamp Cc: Mikhail Teterin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 46mMcZ1w93z49Jh X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Oct 2019 12:00:14 -0000 On Sun, Oct 6, 2019 at 12:11 PM Tobias Kortkamp wrote: > On Sun, Oct 06, 2019 at 11:59:10AM +0400, Gleb Popov wrote: > > On Sun, Oct 6, 2019 at 9:44 AM Tobias Kortkamp > wrote: > > > > > On Thu, Oct 03, 2019 at 05:45:40PM +0000, Mikhail Teterin wrote: > > > > Author: mi > > > > Date: Thu Oct 3 17:45:39 2019 > > > > New Revision: 513679 > > > > URL: https://svnweb.freebsd.org/changeset/ports/513679 > > > > > > > > Log: > > > > Add a patch from upstream, fixing the author's typo in an option's > > > name. > > > > It only affects users of libsecret, which is off by default -- > thus no > > > > port-revision bump. > > > > > > That's not a valid reason not to bump PORTREVISION. Please bump > > > it so that users how happen to build it with LIBSECRET=on get your > > > fix automatically. > > > > > > > I have been told that PORTREVISION should be bumped whenever output > package > > changes. It isn't the case here. Or am I mistaken? > > We do not have options specific PORTREVISIONs and there are more > package repositories than pkg.FreeBSD.org. If you have previously > built your packages with LIBSECRET=on, the applied fix will change > the package in a non-trivial way. However since PORTREVISION was > not bumped Poudriere or other package builders will not rebuild the > package. Bascially people will have to micromanage/force the rebuild > fusefs-smbnetfs if they want this fix. fusefs-smbnetfs is hardly > an expensive package to build so saving rebuilds at the cost of > wasting people's time is not worth it and bad UX. > I see, thanks for explanation.