From owner-svn-ports-all@FreeBSD.ORG  Wed Mar 26 22:18:12 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id AA8344C0;
 Wed, 26 Mar 2014 22:18:12 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 80DB836A;
 Wed, 26 Mar 2014 22:18:12 +0000 (UTC)
Received: from [192.168.0.20] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id A415C43B4E;
 Wed, 26 Mar 2014 17:17:48 -0500 (CDT)
Message-ID: <533351FC.2020908@marino.st>
Date: Wed, 26 Mar 2014 23:17:32 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: Antoine Brodin <antoine@FreeBSD.org>, ports-committers@freebsd.org, 
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r349288 - head/archivers/ocaml-bz2
References: <201403262018.s2QKId7b067131@svn.freebsd.org>
In-Reply-To: <201403262018.s2QKId7b067131@svn.freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Mar 2014 22:18:12 -0000

On 3/26/2014 21:18, Antoine Brodin wrote:
> Author: antoine
> Date: Wed Mar 26 20:18:38 2014
> New Revision: 349288
> URL: http://svnweb.freebsd.org/changeset/ports/349288
> QAT: https://qat.redports.org/buildarchive/r349288/
> 
> Log:
>   Stage support
> 
> Modified:
>   head/archivers/ocaml-bz2/Makefile
> 
> Modified: head/archivers/ocaml-bz2/Makefile
> ==============================================================================
> --- head/archivers/ocaml-bz2/Makefile	Wed Mar 26 20:09:29 2014	(r349287)
> +++ head/archivers/ocaml-bz2/Makefile	Wed Mar 26 20:18:38 2014	(r349288)
> @@ -12,10 +12,9 @@ DISTNAME=	caml${PORTNAME}-${PORTVERSION}
>  MAINTAINER=	jaapb@kerguelen.org
>  COMMENT=	OCaml library to manipulate bz2 files
>  
> +DESTDIRNAME=	DONTUSEIT
>  GNU_CONFIGURE=	yes
>  USES=		gmake
> -NO_STAGE=	yes
> -

You left USE_OCAML_LDCONFIG=     yes.
Won't this create an ldconf file that will get added to plist and will
conflict potentially with the real ldconf?

USE_OCAML_WASH is also set.  Is this knob actually desireable?  Why is
it needed if it's competing with pkg to remove files?

I'm not saying I'm right, I'm just trying to learn this.
John