Date: Wed, 26 Mar 2014 23:26:22 +0100 From: Antoine Brodin <antoine@FreeBSD.org> To: John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r349288 - head/archivers/ocaml-bz2 Message-ID: <CAALwa8khMDfYPetqQ1kivx7g2wCqjezj9RYoZvH22GDjobfuxw@mail.gmail.com> In-Reply-To: <533351FC.2020908@marino.st> References: <201403262018.s2QKId7b067131@svn.freebsd.org> <533351FC.2020908@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 26, 2014 at 11:17 PM, John Marino <freebsd.contact@marino.st> wrote: > On 3/26/2014 21:18, Antoine Brodin wrote: >> Author: antoine >> Date: Wed Mar 26 20:18:38 2014 >> New Revision: 349288 >> URL: http://svnweb.freebsd.org/changeset/ports/349288 >> QAT: https://qat.redports.org/buildarchive/r349288/ >> >> Log: >> Stage support >> >> Modified: >> head/archivers/ocaml-bz2/Makefile >> >> Modified: head/archivers/ocaml-bz2/Makefile >> ============================================================================== >> --- head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:09:29 2014 (r349287) >> +++ head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:18:38 2014 (r349288) >> @@ -12,10 +12,9 @@ DISTNAME= caml${PORTNAME}-${PORTVERSION} >> MAINTAINER= jaapb@kerguelen.org >> COMMENT= OCaml library to manipulate bz2 files >> >> +DESTDIRNAME= DONTUSEIT >> GNU_CONFIGURE= yes >> USES= gmake >> -NO_STAGE= yes >> - > > You left USE_OCAML_LDCONFIG= yes. > Won't this create an ldconf file that will get added to plist and will > conflict potentially with the real ldconf? > > USE_OCAML_WASH is also set. Is this knob actually desireable? Why is > it needed if it's competing with pkg to remove files? > > I'm not saying I'm right, I'm just trying to learn this. Hi, I modifed bsd.ocaml.mk so now USE_OCAML_LDCONFIG doesn't violate stagedir anymore. For USE_OCAML_WASH, I have doubts on its usefulness, maybe it should be garbage collected in all the tree. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8khMDfYPetqQ1kivx7g2wCqjezj9RYoZvH22GDjobfuxw>