From owner-freebsd-stable@freebsd.org  Sun Dec  4 21:57:10 2016
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97721C677BE
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Sun,  4 Dec 2016 21:57:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 82F986E6
 for <freebsd-stable@freebsd.org>; Sun,  4 Dec 2016 21:57:10 +0000 (UTC)
 (envelope-from jhb@freebsd.org)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 7F41FC677BD; Sun,  4 Dec 2016 21:57:10 +0000 (UTC)
Delivered-To: stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EE7FC677BC
 for <stable@mailman.ysv.freebsd.org>; Sun,  4 Dec 2016 21:57:10 +0000 (UTC)
 (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5F1F66E5;
 Sun,  4 Dec 2016 21:57:10 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 7B99310AA28;
 Sun,  4 Dec 2016 16:57:09 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Andrey Chernov <ache@freebsd.org>,
 "stable@freebsd.org" <stable@freebsd.org>
Subject: Re: if_cxgbev build error on -stable
Date: Sun, 04 Dec 2016 13:53:49 -0800
Message-ID: <1720335.GyareAB9U2@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; )
In-Reply-To: <20161204135323.GU54029@kib.kiev.ua>
References: <ca38a6a0-a24e-4d10-4c1e-bd1f83679432@freebsd.org>
 <a3d2151e-3afb-5e0a-d320-3f35db93bc5f@freebsd.org>
 <20161204135323.GU54029@kib.kiev.ua>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Sun, 04 Dec 2016 16:57:09 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Dec 2016 21:57:10 -0000

On Sunday, December 04, 2016 03:53:23 PM Konstantin Belousov wrote:
> On Sun, Dec 04, 2016 at 04:23:00PM +0300, Andrey Chernov wrote:
> > It seems counter.h is included before systm.h where critical_* are declared.
> It is more weird, since sys/counter.h was added in the stable/10
> merge, but the header is not used in the HEAD sources. It is indeed
> needed for stable/10 driver.  critical_enter() pre-requisite for counter.h
> only exists on i386, which probably explains why John' build test did not
> catched it.
> 
> I am preparing another MFC, so I committed the fix in r309529.

Thanks for fixing this.  I had indeed only tested it on amd64.

-- 
John Baldwin