Date: Sat, 26 Aug 1995 01:02:30 -0700 From: "Justin T. Gibbs" <gibbs@freefall.FreeBSD.org> To: Mark Murray <mark@grondar.za> Cc: Mark Murray <markm@freefall.FreeBSD.org>, CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Message-ID: <199508260802.BAA28060@freefall.FreeBSD.org> In-Reply-To: Your message of "Sat, 26 Aug 95 08:44:19 %2B0200." <199508260644.IAA25059@grumble.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
>Yes. The code had not been maintained by its original author(s) in many years >(since 1989). I had been asking for a while for code reviewers and help etc, >and found little. If the diffs had been sent to me, I would have reviewed them just as I had orignally promised some month or so ago. I make this offer once again since I'm currently working in eBones bringing in the work of an outside author. >I then went qnd found a couple of up-to-date (newish) >pieces of BSD code (I can't remember which, now) and modeled the coding >style on them. Maybe its just me since almost all of my work has been in the kernel and 95% of the kernel follows the first style (including new code). >The old code was _really_ bad. In many places there were no or conflicting >function definitions, and the easiest way to generate headers was to do >them in-place. I have not problem with you fixing the function definitions to be consistent, but that did not require changing the format of 35% of the definitions so that they aren't consistent with the format of the ones you haven't touched. >It is _not_ my intention to do this to every piece of code I touch. I just >did it here to jack the code back up into the 20th century. Which means that the code will continue to be inconsistent in format. >> I don't view this as a cleanup at all. It makes unnecessary conflicts with >> the original code and makes it more difficult to incomperate patches from >> outside sources. > >I understand your reservations, but there has been little or no movement in >this code since 1989, and it is suffering badly from bit rot. We have just >about the whole eBones source in our tree now, and anything else just needs >the headers. Well, it certainly spammed all of my work in bringing in Dieter Dworkin Muller's multi-homed server fixes to eBones, so the scenario was not contrived at all. > >M >-- >Mark Murray >46 Harvey Rd, Claremont, Cape Town 7700, South Africa >+27 21 61-3768 GMT+0200 >Finger mark@grumble.grondar.za for PGP key -- Justin T. Gibbs =========================================== Software Developer - Walnut Creek CDROM FreeBSD: Turning PCs into workstations ===========================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508260802.BAA28060>