From owner-freebsd-ports@FreeBSD.ORG Sun May 24 08:38:48 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C91511065673; Sun, 24 May 2009 08:38:48 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98]) by mx1.freebsd.org (Postfix) with ESMTP id 7E4B18FC38; Sun, 24 May 2009 08:38:48 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from it.buh.tecnik93.com (localhost [127.0.0.1]) by it.buh.tecnik93.com (Postfix) with ESMTP id A12AE2C50CC3; Sun, 24 May 2009 11:39:15 +0300 (EEST) Date: Sun, 24 May 2009 11:39:03 +0300 From: Ion-Mihai Tetcu To: David Naylor Message-ID: <20090524113903.015920cf@it.buh.tecnik93.com> In-Reply-To: <200905241026.26903.naylor.b.david@gmail.com> References: <20090523.182426.193741786.chat95@mac.com> <200905231318.29346.naylor.b.david@gmail.com> <20090524.071637.35088168.chat95@mac.com> <200905241026.26903.naylor.b.david@gmail.com> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/=X/8HWyo0tbyUuhst2oZMov"; protocol="application/pgp-signature" Cc: pgollucci@p6m7g8.com, pav@freebsd.org, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2009 08:38:49 -0000 --Sig_/=X/8HWyo0tbyUuhst2oZMov Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 24 May 2009 10:26:23 +0200 David Naylor wrote: > On Sunday 24 May 2009 00:16:37 Maho NAKATA wrote: > > Hi I tested it yesterday, > > > > 1. > > I need > > > > > MAKE_JOBS_SAFE=3D yes > > > > in the Makefile. >=20 > Yes, you would need that. I believe that will be default. =20 >=20 > > 2. with above patch, ooo2 doesn't launch parallele jobs. >=20 > I spotted that problem after submitting the patch, if you explicitly > set MAKE_JOBS_NUMBER to something it will work.=20 >=20 > The problem is that ooo2 does (in effect): > .if (${MAKE_JOBS_NUMBER} > 1) > # Stuff > .else > # Other stuff > .endif > and that doesn't work as expected with MAKE_JOBS_NUMBER=3D`sysctl > kern.smp.cpus` as the command is not resolved. =20 Adding MAKE_JOBS_NUMBER!=3D`sysctl kern.smp.cpus` in the port Makefile should help. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/=X/8HWyo0tbyUuhst2oZMov Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAkoZB7MACgkQJ7GIuiH/oeUCxQCgncNRHb8fS37a+Bs6dIwWiILo XZoAoJ5pKEGVwbZpVRzvTyp2VI0EKqhh =Broy -----END PGP SIGNATURE----- --Sig_/=X/8HWyo0tbyUuhst2oZMov--