From owner-cvs-src@FreeBSD.ORG  Tue Jan 23 17:08:37 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6E7B516A404
	for <cvs-src@FreeBSD.org>; Tue, 23 Jan 2007 17:08:37 +0000 (UTC)
	(envelope-from nate@root.org)
Received: from root.org (root.org [67.118.192.226])
	by mx1.freebsd.org (Postfix) with ESMTP id 4DE7C13C459
	for <cvs-src@FreeBSD.org>; Tue, 23 Jan 2007 17:08:37 +0000 (UTC)
	(envelope-from nate@root.org)
Received: (qmail 59541 invoked from network); 23 Jan 2007 17:08:37 -0000
Received: from ppp-71-139-39-138.dsl.snfc21.pacbell.net (HELO ?10.0.5.59?)
	(nate-mail@71.139.39.138)
	by root.org with ESMTPA; 23 Jan 2007 17:08:37 -0000
Message-ID: <45B6410B.2090107@root.org>
Date: Tue, 23 Jan 2007 09:08:27 -0800
From: Nate Lawson <nate@root.org>
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <20070122043408.4171816A492@hub.freebsd.org>	<45B5AE3B.6010005@root.org>
	<20070123.012823.1341031192.imp@bsdimp.com>
In-Reply-To: <20070123.012823.1341031192.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jan 2007 17:08:37 -0000

M. Warner Losh wrote:
> In message: <45B5AE3B.6010005@root.org>
>             Nate Lawson <nate@root.org> writes:
> : Warner Losh wrote:
> : > imp         2007-01-22 04:34:03 UTC
> : > 
> : >   FreeBSD src repository
> : > 
> : >   Modified files:
> : >     sys/cam/scsi         scsi_da.c 
> : >   Log:
> : >   Add quirk for EasyMP3 EM732X usb 2.0 flash mp3 player.
> : >   (It appears that the quirk proceedures link has disappeared and that
> : >   this PR complied with it, if there's a problem, please contact me).
> : >   
> : >   PR: usb/96546
> : >   
> : >   Revision  Changes    Path
> : >   1.201     +8 -0      src/sys/cam/scsi/scsi_da.c
> : > 
> : > 
> : > Index: src/sys/cam/scsi/scsi_da.c
> : > diff -u src/sys/cam/scsi/scsi_da.c:1.200 src/sys/cam/scsi/scsi_da.c:1.201
> : > --- src/sys/cam/scsi/scsi_da.c:1.200	Tue Dec  5 07:45:28 2006
> : > +++ src/sys/cam/scsi/scsi_da.c	Mon Jan 22 04:34:03 2007
> : > @@ -466,6 +466,14 @@
> : >  		{T_DIRECT, SIP_MEDIA_REMOVABLE, "X-Micro", "Flash Disk",
> : >  		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
> : >  	},
> : > +	{
> : > +		/*
> : > +		 * EasyMP3 EM732X USB 2.0 Flash MP3 Player
> : > +		 * PR: usb/96546
> : > +		 */
> : > +		{T_DIRECT, SIP_MEDIA_REMOVABLE, "*", "MP3 Player*",
> : > +		"1.0"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
> : > +	},
> : >  };
> : >  
> : >  static	disk_strategy_t	dastrategy;
> : 
> : Um, this matches every device that has "MP3 Player" somewhere in it. 
> : Are you sure it doesn't have a vendor string?
> 
> See the PR for details and suggest something better.
> 
> Warner

According to the submitter:
pass0: <EM732X MP3 Player 1.00> Removable Direct Access SCSI-0 device

So the vendor string should be set to "EM732X" and retested.  Blank 
("*") vendor or device strings should not be committed.

-- 
Nate