From owner-svn-src-head@freebsd.org Thu Feb 22 16:19:11 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20BA0F1344D; Thu, 22 Feb 2018 16:19:11 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E3A26B3CA; Thu, 22 Feb 2018 16:19:10 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x231.google.com with SMTP id 70so8195882lfw.2; Thu, 22 Feb 2018 08:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=tiu5MskbkIBXsH2186jfC5XT3gvvmqy+s7lb/i4mUz8=; b=IbnTO/v8oCCUFjb18jgDOmtw57t4OAOJRuWwJEM9EhoBFsJkcaBO5p3Oeiw/42+7jZ dirti4jZ0avHsgZa6Npef2A/e/+LYAl1/uurm//9MqjBDTwpmhGy1y13kdm+vPTiv6me +tPH7S4yFLRUtfud1XHK5DtQrsVGbhS4AwiQJRZkECOukd64fVIojLuDhKzpQJ6ZZxhs mEHnJYyp8xqUypzyhlLNb8KiyBHwEC6DbHfFyrhmDkKRtGKzHAWAHUaL2AfesjTwdPyp iB9IICrJCbcJt0Tmotf5eTGu/o8iOPTWFa1ZSHN250pLGasTBsw4AFuGZHYz+5E6mLRJ jhjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=tiu5MskbkIBXsH2186jfC5XT3gvvmqy+s7lb/i4mUz8=; b=nAhO8z7sxNy7Rk08PxpMaCPO3LW/4IThpJlUNYTDQDwDImPDkbVvGGZhexdwIIqvQn nlUb43eiXB26VZPWSrksC/ZxuaDgJZ2wv5mSU4ELIIOKBFw88AqJa8LpRZ3q1o4T45AE I0W4JbI3CTgf6NsQmaVXJoYmVa09FBuNaCVnDwqjv+7awtQN8fjNrvunlF0j9YlKgmqT bhCXjPfcfEYn05zNppH/Y8rs9I3xaw2oG367tGvgrpZ2mIONk76hYFp0XQZ6RCVT1Imo gVqpLrp5ziuLLy2Di/PqWnvlkJIRgx2PLjERHoQliCajPLNpQlkqBElH9IEG9KS9HSKz C3ow== X-Gm-Message-State: APf1xPCgLdUm76jIfsVnOYNE9Rb3N9br4b0BiTSj/2RClk8nhqrBTewC F7xeDu9yy7OW9Pbwbxjok7WSyaqcaWTeVGUCr6txSv86 X-Google-Smtp-Source: AH8x224bcdSBxnInsIb9rVtjYlE9SJ6NHZPW5INLvozfjlnXvFDv2DUR16YNKckX5gG6x8DfwpbqavxfrIHsB9B671U= X-Received: by 10.46.20.30 with SMTP id u30mr5561205ljd.12.1519316348789; Thu, 22 Feb 2018 08:19:08 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.30.66 with HTTP; Thu, 22 Feb 2018 08:19:08 -0800 (PST) In-Reply-To: <201802221332.w1MDWVao004564@repo.freebsd.org> References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Alan Somers Date: Thu, 22 Feb 2018 09:19:08 -0700 X-Google-Sender-Auth: ys7t9vlgK6LJPug_xpVA2oYtjLM Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Wojciech Macek Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:19:11 -0000 On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > Author: wma > Date: Thu Feb 22 13:32:31 2018 > New Revision: 329824 > URL: https://svnweb.freebsd.org/changeset/base/329824 > > Log: > NVMe: Add big-endian support > > Remove bitfields from defined structures as they are not portable. > Instead use shift and mask macros in the driver and nvmecontrol > application. > > NVMe is now working on powerpc64 host. > > Submitted by: Michal Stanek > Obtained from: Semihalf > Reviewed by: imp, wma > Sponsored by: IBM, QCM Technologies > Differential revision: https://reviews.freebsd.org/D13916 > It looks like this change broke the build with Clang: --- ioctl.pico --- In file included from ioctl.c:32: In file included from /usr/home/alans/freebsd/head/sys/cam/scsi/scsi_pass.h:35: In file included from /usr/home/alans/freebsd/head/sys/cam/cam_ccb.h:46: In file included from /usr/home/alans/freebsd/head/sys/cam/nvme/nvme_all.h:34: /usr/home/alans/freebsd/head/sys/dev/nvme/nvme.h:1187:26: error: unused parameter 'p' [-Werror,-Wunused-parameter] void nvme_le128toh(void *p) -Alan